[Bug 35221] New: TrackLastPatronActivityTriggers description is misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Bug ID: 35221 Summary: TrackLastPatronActivityTriggers description is misleading Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The description of the new TrackLastPatronActivityTriggers system preference says "The first time each day that one of these activities occurs, borrowers.lastseen will update with the current date and time." To me, this means that no matter how many times I do one of the actions, the date will not change. However, that is not true. The date is updated on each action of each selected type. To recreate: 1. Go to Administration > System preferences > TrackLastPatronActivityTriggers 2. Check the "Checking out an item" option 3. Click Save all Patron preferences 4. Go to a patron account 5. Check the date last seen in the database (where X is the patron's borrowernumber) SELECT lastseen FROM borrowers WHERE borrowernumber = X 5. Check out an item to the patron 6. Check the date last seen, it should have been updated to the checkout date and time 7. Check out a second item to the patron 8. Check the date last seen, it should have been updated to the second checkout date and time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Also, while we're there, could we choose between the present participle tense, the simple present tense and the noun for the options? Simple present tense - Places an article request Present participle tense - Checking out an item - Placing a hold on an item - Renewing an item - Returning an item --> Should be Checking in an item according to terminology Noun - Connection to Koha via SIP or ILSDI - Login -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 158212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158212&action=edit Bug 35221: TrackLastPatronActivityTriggers description is misleading This patch updates the description for the TrackLastPatronActivityTriggers system preference to specify that each time an action occurs, the date last seen is updated, as opposed to once per day. This patch also uniformizes the options and corrects terminology for checking in/returning. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for TrackLastPatronActivityTriggers 4. Read the description, make sure it makes sense and the spelling and grammar are correct 5. Open the drop down of options, make sure the spelling and grammar are correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Bug 35221 depends on bug 15504, which changed state. Bug 15504 Summary: Track Patron's Last Activity https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158212|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 158220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158220&action=edit Bug 35221: TrackLastPatronActivityTriggers description is misleading This patch updates the description for the TrackLastPatronActivityTriggers system preference to specify that each time an action occurs, the date last seen is updated, as opposed to once per day. This patch also uniformizes the options and corrects terminology for checking in/returning. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for TrackLastPatronActivityTriggers 4. Read the description, make sure it makes sense and the spelling and grammar are correct 5. Open the drop down of options, make sure the spelling and grammar are correct Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Caroline! I noted this when writing the release note - but you bet me to it! David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158220|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158439&action=edit Bug 35221: TrackLastPatronActivityTriggers description is misleading This patch updates the description for the TrackLastPatronActivityTriggers system preference to specify that each time an action occurs, the date last seen is updated, as opposed to once per day. This patch also uniformizes the options and corrects terminology for checking in/returning. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for TrackLastPatronActivityTriggers 4. Read the description, make sure it makes sense and the spelling and grammar are correct 5. Open the drop down of options, make sure the spelling and grammar are correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 15504 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org