[Bug 13697] New: Option to don't add a fee, if the patron changes to a category with enrolment fee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Bug ID: 13697 Summary: Option to don't add a fee, if the patron changes to a category with enrolment fee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a borrower's category is changed during his subscription (i.e : a child who moves to adult) if category adult in this case have an enrolment fee, fees are added. Many libraries do not want these fees in these cases. So I have made a patch to offer this choice via a system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 35831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35831&action=edit Option to don't add a fee, if the patron changes to a category with enrolment fee thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- This needs a test plan and tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Test plan : 1/ create 2 categories (A & B). B with enrolment fee 2/ create a patron in category A 3/ change the patron category from A to B 4/ check that the patron has an enrolment fee to pay Apply the patch 1/ create a new patron in category A 2/ change the patron category from A to B. 3/ check that the patron has an enrolment fee to pay 4/ change the system preference => UPDATE `systempreferences` SET `value` = '1' WHERE `systempreferences`.`variable` ='FeeOnChangePatronCategory'; 5/ create a new patron in category A 6/ change the patron category from A to B 7/ check that the patron has no enrolment fee to pay thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35831|0 |1 is obsolete| | --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 36234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36234&action=edit Syspref to not add a fee when a patron changes to a category with enrolment fee Test plan : 1/ create 2 categories (A & B). B with enrolment fee 2/ create a patron in category A 3/ change the patron category from A to B 4/ check that the patron has an enrolment fee to pay Apply the patch 1/ create a new patron in category A 2/ change the patron category from A to B. 3/ check that the patron has an enrolment fee to pay 4/ change the system preference 'FeeOnChangePatronCategory' to 'Don't'; 5/ create a new patron in category A 6/ change the patron category from A to B 7/ check that the patron has no enrolment fee to pay thx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Option to don't add a fee, |Syspref to not add a fee |if the patron changes to a |when a patron changes to a |category with enrolment fee |category with enrolment fee -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Juliane <jcasier@ville-roubaix.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcasier@ville-roubaix.fr --- Comment #5 from Juliane <jcasier@ville-roubaix.fr> --- Ok, tested and it works. Case 1 tested: the patron has already a category with enrolment fee, I change it to another category with enrolment fee, the patron has no enrolment fee to pay Case 2 tested : the patron has a free category , I change it to a category with enrolment fee, the patron has no enrolment fee to pay Howether, I created the 13792 bugzilla : testing make me realise a bug about payment on fees on the master version of koha (not linked to this patch) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36234|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37048&action=edit [PASSED QA] Bug 13697 : Syspref to not add a fee when a patron changes to a category with enrolment fee By default this syspref is "Do" to keep the previous behaviour. Test plan : 1/ create 2 categories (A & B). B with enrolment fee 2/ create a patron in category A 3/ change the patron category from A to B 4/ check that the patron has an enrolment fee to pay Apply the patch 1/ create a new patron in category A 2/ change the patron category from A to B. 3/ check that the patron has an enrolment fee to pay 4/ change the system preference 'FeeOnChangePatronCategory' to 'Don't'; 5/ create a new patron in category A 6/ change the patron category from A to B 7/ check that the patron has no enrolment fee to pay Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37049&action=edit Bug 13697 [QA Followup] - Add Unit Test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 42076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42076&action=edit Bug 13697: (QA followup) idiomatic fix add > charge Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Christophe and Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 42122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42122&action=edit Bug 13697: (QA followup) fix typo in sysprefs.sql Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #11 from Nicole C. Engard <nengard@gmail.com> --- I'm writing this up for the manual. It's under Norwegian Patron Database - does that mean this does not apply to patrons edited via Koha in other countries? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nicole C. Engard from comment #11)
I'm writing this up for the manual. It's under Norwegian Patron Database - does that mean this does not apply to patrons edited via Koha in other countries?
Nicole
No! That's a bug me thinks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15073 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 [Bug 15073] FeeOnChangePatronCategory in wrong place -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- All better: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org