[Bug 12861] New: Noisy warns in C4/AuthoritiesMarc.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Bug ID: 12861 Summary: Noisy warns in C4/AuthoritiesMarc.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org If you hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY You will see a lot of this opac-authorities-home.pl: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 146, <DATA> line 522. In the error logs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 31324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31324&action=edit Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- - else { # Assume any if no index was specified - $attr = " \@attr 1=Any "; - }
From glancing thru this code: The place of this else in the old code and in the new code is different. In the new code you are not reaching this point anymore.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31324|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32782&action=edit Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32782|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 35304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35304&action=edit Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 172. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 176. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 179. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 183. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35308&action=edit Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m Assignee|oleonard@myacpl.org |chris@bigballofwax.co.nz --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Could I get a signoff on the second patch please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35308|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 35360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35360&action=edit Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35304|0 |1 is obsolete| | Attachment #35360|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35364&action=edit Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35365&action=edit Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Chris and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to Chris Cormack from comment #12)
Pushed to 3.18.x will be in 3.18.4
Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org