[Bug 8917] New: Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Priority: P5 - low Change sponsored?: --- Bug ID: 8917 Assignee: oleonard@myacpl.org Summary: Track clicks to links external to Koha Severity: enhancement Classification: Unclassified OS: All Reporter: chris@bigballofwax.co.nz Hardware: All Status: NEW Version: master Component: OPAC Product: Koha It would be nice to be able to track if patrons clicked on links inside records to visit links external to Koha. (Ebooks, databases etc). This should be stored in it's own database table, and a system preference should control if it is used, and also if it stores identifying information or not. TrackClicks - No - Yes anonymously - Yes link to borrowers if logged in Off by default. This data can then be retrieved by a crafted sql report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Development sponsored by Albany Senior High School -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12831&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12832&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12833&action=edit Bug 8917 : Script to log link clicks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12834&action=edit Bug 8917 : Link tracking, changes to XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- To test Apply patches, ... nothing should change. Switch the TrackClicks syspref to anonymous. View a result with a link, the link should be changed, clicking on it should take you to the real link, but a row should be inserted into the linktracker table. The borrowernumber should be 0 Switch the syspref to Track Try the link again, if you are not logged in borrower will still be 0 If you are logged in, it should have your borrowernumber logged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- When TrackClicks is set to track, clicking a link gives this error: Can't use string ("") as a HASH ref while "strict refs" in use at /home/koha/kohaclone/C4/Auth.pm line 1624. It does, however, work fine when set to track anonymously. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12831|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12998&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12832|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12999&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12833|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13000&action=edit Bug 8917 : Script to log link clicks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12834|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13001&action=edit Bug 8917 : Link tracking, changes to XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #7)
When TrackClicks is set to track, clicking a link gives this error:
Can't use string ("") as a HASH ref while "strict refs" in use at /home/koha/kohaclone/C4/Auth.pm line 1624.
It does, however, work fine when set to track anonymously.
How exactly did you get this error? I can't recreate it, were you logged in at the time? Or not logged in? I have rebased all the patches against the current HEAD of master, so if you can let me know how you got the error ill try to recreate and fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> ---
How exactly did you get this error? I can't recreate it, were you logged in at the time? Or not logged in?
I have rebased all the patches against the current HEAD of master, so if you can let me know how you got the error ill try to recreate and fix it.
I tried it both logged in and logged out iirc. I'll have to retest and see if I still get those errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Tested, I get the error when I am logged in. I tried it as two separate users and got the same error each time. Can't use string ("") as a HASH ref while "strict refs" in use at /home/koha/kohaclone/C4/Auth.pm line 1625. If I'm not logged in, it works fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- The feature works for me. I can't reproduce the error describes by Kyle. Given that Kyle get an error, I don't sign-off this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Could someone else please test, Kyle is getting an error that currently neither Jonathan or I can reproduce. If someone else could test as well that would be great. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- I cannot apply the last patch. I'll attempt to retest the rest of them though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- I think I'm giving up on testing this one. I just did a full reinstall from master, with only the default data. I changed nothing except to enable TrackClicks, and catalog an item with a URL, and I *still* get the error: Can't use string ("") as a HASH ref while "strict refs" in use at /home/koha/kohaclone/C4/Auth.pm line 1625. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12998|0 |1 is obsolete| | --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14058&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12999|0 |1 is obsolete| | --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14059&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13000|0 |1 is obsolete| | --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14060&action=edit Bug 8917 : Script to log link clicks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13001|0 |1 is obsolete| | --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14061&action=edit Bug 8917 : Link tracking, changes to XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Does not apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14058|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15669&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14059|0 |1 is obsolete| | --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15670&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14060|0 |1 is obsolete| | --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15671&action=edit Bug 8917 : Script to log link clicks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14061|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15672&action=edit Bug 8917 : Link tracking, changes to XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Well, I found Kyle's problem with logged in user. Software error: Can't use string ("") as a HASH ref while "strict refs" in use at /home/bgkriegel/kohaclone/C4/Auth.pm line 1682 Digging a little, I found: 1) in tracklinks.pl you call "checkauth( $cgi, 1, '', 'opac' );" 2) in C4/Auth.pm ^ THIS sub checkauth { my $query = shift; $debug and warn "Checking Auth"; # $authnotrequired will be set for scripts which will run without authentication my $authnotrequired = shift; my $flagsrequired = shift; <----------- HERE my $type = shift; my $persona = shift; $type = 'opac' unless $type; 3) some lines later, $flagsrequired is used in $flags = haspermission($userid, $flagsrequired); 4) more lines later, in haspermission() (1682) foreach my $module ( keys %$flagsrequired ) { And that's the error's line. 5) $flagsrequired need to be a hashref, you send '' 6) If I change 1) to checkauth( $cgi, 1, {}, 'opac' ); now Koha is happy and logs the correct user in linktracker table. (Perl (v5.14.2) built for x86_64-linux-gnu-thread-multi) Perhaps declaring args and then using them in checkout() would be cleaner and more understandable. 7) Not related, koha-qa complains of tabulations in updatedatabase.pl, I could fix that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #28)
Perhaps declaring args and then using them in checkout() Sorry, I mean checkauth()
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15711&action=edit Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15669|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15712&action=edit [SIGNED-OFF] Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15670|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15713&action=edit [SIGNED-OFF] Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15671|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15714&action=edit [SIGNED_OFF] Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15672|0 |1 is obsolete| | --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15715&action=edit [SIGNED_OFF] Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15711|0 |1 is obsolete| | --- Comment #35 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15716&action=edit [SIGNED-OFF] Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Signed-off. Work as described. No errors. Tests 1) Syspref disabled, no tracking 2) Syspref enabled to anonymous, tracking with borrowernumber 0, anonymous search or logged in. 3) Syspref enabled to track, tracking, borrowernumber depends, 0 for anonymous search, borrowernumber for logged in user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 15713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15713 [SIGNED-OFF] Bug 8917 : Adding link tracking to the opac detail page, without xslt Review of attachment 15713: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8917&attachment=15713) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ +716,4 @@
<br />[% END %] <!-- here you might do a tmpl_if name="toc" and use greybox or equivalent for table of contents -->
+ [% IF ( MARCurl.OPACurlOpenInNewWindow ) %]
This is always false. The variable to test is OPACurlOpenInNewWindow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 15714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15714 [SIGNED_OFF] Bug 8917 : Script to log link clicks Review of attachment 15714: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8917&attachment=15714) ----------------------------------------------------------------- ::: opac/tracklinks.pl @@ +65,5 @@
+ print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early + exit; +} + +sub trackclick {
Don't we want to have this routine into a new module (in order to prevent sql code into pl file)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marked as Failed QA for the test on the wrong variable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #40 from Chris Cormack <chris@bigballofwax.co.nz> --- Ahh someone must have fixed that since the patch was first made http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12832&action=diff I'll change the patch and resubmit -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15712|0 |1 is obsolete| | --- Comment #41 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15783&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15713|0 |1 is obsolete| | --- Comment #42 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15784&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15714|0 |1 is obsolete| | --- Comment #43 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15785&action=edit Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15715|0 |1 is obsolete| | --- Comment #44 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15786&action=edit Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15716|0 |1 is obsolete| | --- Comment #45 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15787&action=edit Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #38)
Comment on attachment 15714 [details] [review] [SIGNED_OFF] Bug 8917 : Script to log link clicks
Review of attachment 15714 [details] [review]: -----------------------------------------------------------------
::: opac/tracklinks.pl @@ +65,5 @@
+ print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early + exit; +} + +sub trackclick {
Don't we want to have this routine into a new module (in order to prevent sql code into pl file)?
Hi Chris, You didn't address this remark, isn't it relevant? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #47 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #46)
(In reply to comment #38)
Comment on attachment 15714 [details] [review] [review] [SIGNED_OFF] Bug 8917 : Script to log link clicks
Review of attachment 15714 [details] [review] [review]: -----------------------------------------------------------------
::: opac/tracklinks.pl @@ +65,5 @@
+ print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early + exit; +} + +sub trackclick {
Don't we want to have this routine into a new module (in order to prevent sql code into pl file)?
Hi Chris, You didn't address this remark, isn't it relevant?
I didn't think it was, no. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #47)
(In reply to comment #46)
(In reply to comment #38)
Comment on attachment 15714 [details] [review] [review] [review] [SIGNED_OFF] Bug 8917 : Script to log link clicks
Review of attachment 15714 [details] [review] [review] [review]: -----------------------------------------------------------------
::: opac/tracklinks.pl @@ +65,5 @@
+ print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early + exit; +} + +sub trackclick {
Don't we want to have this routine into a new module (in order to prevent sql code into pl file)?
Hi Chris, You didn't address this remark, isn't it relevant?
I didn't think it was, no.
So please set out your argument, mine is the coding guidelines : http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #49 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #48)
(In reply to comment #47)
(In reply to comment #46)
(In reply to comment #38)
Comment on attachment 15714 [details] [review] [review] [review] [review] [SIGNED_OFF] Bug 8917 : Script to log link clicks
Review of attachment 15714 [details] [review] [review] [review] [review]: -----------------------------------------------------------------
::: opac/tracklinks.pl @@ +65,5 @@
+ print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early + exit; +} + +sub trackclick {
Don't we want to have this routine into a new module (in order to prevent sql code into pl file)?
Hi Chris, You didn't address this remark, isn't it relevant?
I didn't think it was, no.
So please set out your argument, mine is the coding guidelines : http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_. pl_scripts
I no longer care, someone else can work on this -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- Chris, I feel like you are upset. Did I offense you? If it is the case, I am sorry, I didn't mean it. I am just trying to do my QA job, and this job consists in following the coding guidelines. I just would like to understand why do you think this remark is no relevant, because I though i was. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #51 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15812&action=edit Bug 8917 : Shifting db dependent code to a module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #52 from Chris Cormack <chris@bigballofwax.co.nz> --- Shifted the db insert to a new module. Spotted a bug with the behaviour of the links that existed before this new feature, even if we dont have a uri, we are putting an empty href in. Will do a follow up to fix this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #53 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15815&action=edit Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15783|0 |1 is obsolete| | --- Comment #54 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15818&action=edit [SIGNED-OFF] Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15784|0 |1 is obsolete| | --- Comment #55 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15819&action=edit [SIGNED-OFF] Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15785|0 |1 is obsolete| | --- Comment #56 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15820&action=edit [SIGNED-OFF] Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15786|0 |1 is obsolete| | --- Comment #57 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15821&action=edit [SIGNED-OFF] Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15787|0 |1 is obsolete| | --- Comment #58 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15822&action=edit [SIGNED-OFF] Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15812|0 |1 is obsolete| | --- Comment #59 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15823&action=edit [SIGNED-OFF] Bug 8917 : Shifting db dependent code to a module Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15815|0 |1 is obsolete| | --- Comment #60 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15824&action=edit [SIGNED-OFF] Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> General comment: Work as described. No errors. Tested all preference values with and without logged in user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #61 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15825&action=edit Bug 8917 : [ Sign followup ] Track clicks to links external to Koha Remove empty pod section in Koha/Linktracker.pm to make koha-qa happy. Add missing "\n" in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch add a link tracker at the OPAC for the result and detail pages. The feature works as expected without XSLT (3 options tested). I didn't test the pages with XSLT, I am a unimarc user and this patch does not modify the unimarc XSLTs. Marked as Passed QA. Note: the update database message is not correct ("Adds feature Bug 8917, the ability to track links clicked"). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15818|0 |1 is obsolete| | Attachment #15819|0 |1 is obsolete| | Attachment #15820|0 |1 is obsolete| | Attachment #15821|0 |1 is obsolete| | Attachment #15822|0 |1 is obsolete| | Attachment #15823|0 |1 is obsolete| | Attachment #15824|0 |1 is obsolete| | Attachment #15825|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15850&action=edit Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15851&action=edit Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #65 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15852&action=edit Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #66 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15853&action=edit Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15854&action=edit Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #68 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15855&action=edit Bug 8917 : Shifting db dependent code to a module Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15856&action=edit Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> General comment: Work as described. No errors. Tested all preference values with and without logged in user. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15857&action=edit Bug 8917 : [ Sign followup ] Track clicks to links external to Koha Remove empty pod section in Koha/Linktracker.pm to make koha-qa happy. Add missing "\n" in installer/data/mysql/updatedatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15858&action=edit Bug 8917: replaces tab with spaces Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #72 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #73 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Is somebody planning to write a followup bug for UNIMARC XSLT? M. Saby -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org