[Bug 32628] New: Add 'page-section' to various serials pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Bug ID: 32628 Summary: Add 'page-section' to various serials pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 A few serials templates need to have main content wrapped in a "page-section" container. - serials/subscription-batchedit.tt - serials/subscription-frequencies.tt - serials/viewalerts.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145276&action=edit Bug 32628: Add 'page-section' to various serials pages This patch adds a "page-section" container div around the main section of serials pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test you must have at least one subscription in your system. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Subscription batch edit: - Go to Serials -> Search subscriptions -> Results - Check the box next to one or more search results and click "Edit selected serials." - Subscription frequencies: - Serials -> Manage frequencies - View subscription alerts: - Log in to the OPAC and search for a subscription. - On the subscription detail page click the "Subscribe to to email notification on new issues." - In the staff interface, locate that subscription and view its details. - Click the "subscribers" link under "Patron notification." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145276|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145326&action=edit Bug 32628: Add 'page-section' to various serials pages This patch adds a "page-section" container div around the main section of serials pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test you must have at least one subscription in your system. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Subscription batch edit: - Go to Serials -> Search subscriptions -> Results - Check the box next to one or more search results and click "Edit selected serials." - Subscription frequencies: - Serials -> Manage frequencies - View subscription alerts: - Log in to the OPAC and search for a subscription. - On the subscription detail page click the "Subscribe to to email notification on new issues." - In the staff interface, locate that subscription and view its details. - Click the "subscribers" link under "Patron notification." Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145326|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145336&action=edit Bug 32628: Add 'page-section' to various serials pages This patch adds a "page-section" container div around the main section of serials pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test you must have at least one subscription in your system. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Subscription batch edit: - Go to Serials -> Search subscriptions -> Results - Check the box next to one or more search results and click "Edit selected serials." - Subscription frequencies: - Serials -> Manage frequencies - View subscription alerts: - Log in to the OPAC and search for a subscription. - On the subscription detail page click the "Subscribe to to email notification on new issues." - In the staff interface, locate that subscription and view its details. - Click the "subscribers" link under "Patron notification." Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Bug 32628 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org