[Bug 23315] New: Some system preferences are no longer editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Bug ID: 23315 Summary: Some system preferences are no longer editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 21582 removed htmlarea in favour or textarea in the system preferences. However 5 instances of html area remain one in circulation.pref and 4 in staff_client.pref This renders those 5 systempreferences uneditable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |21582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 [Bug 21582] Use CodeMirror for *UserJS & *UserCSS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 91521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91521&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91526&action=edit Bg 23315 : Some systempreferences can not be edited To test 1/ Go to systempreferences 2/ Notice that SelfCheckHelpMessage IntranetmainUserblock IntranetCirculationHomeHTML IntranetReportsHomeHTML StaffLoginInstructions are not editable 3/ Apply patch, refresh page 4/ Now they can be edited Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91527&action=edit Bug 23315: (follow-up) Add configuration to enable CodeMirror This patch adds the "syntax" parameter to the corrected system preferences so that the textareas will be displayed as CodeMirror editors. To test, apply the patch and test the affected system preferences: Circulation -> SelfCheckHelpMessage Staff client -> IntranetmainUserblock Staff client -> IntranetCirculationHomeHTML Staff client -> IntranetReportsHomeHTML Staff client -> StaffLoginInstructions With UseWYSIWYGinSystemPreferences disabled, the preferences should be displayed as CodeMirror editors. With UseWYSIWYGinSystemPreferences enabled they should be WYSIWYG editors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chris@bigballofwax.co.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91521|0 |1 is obsolete| | Attachment #91526|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 91541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91541&action=edit Bug 23315 : Some systempreferences can not be edited To test 1/ Go to systempreferences 2/ Notice that SelfCheckHelpMessage IntranetmainUserblock IntranetCirculationHomeHTML IntranetReportsHomeHTML StaffLoginInstructions are not editable 3/ Apply patch, refresh page 4/ Now they can be edited Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91527|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 91542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91542&action=edit Bug 23315: (follow-up) Add configuration to enable CodeMirror This patch adds the "syntax" parameter to the corrected system preferences so that the textareas will be displayed as CodeMirror editors. To test, apply the patch and test the affected system preferences: Circulation -> SelfCheckHelpMessage Staff client -> IntranetmainUserblock Staff client -> IntranetCirculationHomeHTML Staff client -> IntranetReportsHomeHTML Staff client -> StaffLoginInstructions With UseWYSIWYGinSystemPreferences disabled, the preferences should be displayed as CodeMirror editors. With UseWYSIWYGinSystemPreferences enabled they should be WYSIWYG editors. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91541|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91611&action=edit Bug 23315 : Some systempreferences can not be edited To test 1/ Go to systempreferences 2/ Notice that SelfCheckHelpMessage IntranetmainUserblock IntranetCirculationHomeHTML IntranetReportsHomeHTML StaffLoginInstructions are not editable 3/ Apply patch, refresh page 4/ Now they can be edited Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91542|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91612&action=edit Bug 23315: (follow-up) Add configuration to enable CodeMirror This patch adds the "syntax" parameter to the corrected system preferences so that the textareas will be displayed as CodeMirror editors. To test, apply the patch and test the affected system preferences: Circulation -> SelfCheckHelpMessage Staff client -> IntranetmainUserblock Staff client -> IntranetCirculationHomeHTML Staff client -> IntranetReportsHomeHTML Staff client -> StaffLoginInstructions With UseWYSIWYGinSystemPreferences disabled, the preferences should be displayed as CodeMirror editors. With UseWYSIWYGinSystemPreferences enabled they should be WYSIWYG editors. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23315 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- not needed in 18.11.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org