https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #2 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 121440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121440&action=edit Bug 27948: Add ArticleRequestsDisclaimerText syspref -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121440|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 121506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121506&action=edit Bug 27948: Add ArticleRequestsDisclaimerText syspref Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement lets you release notes| |include text that patrons | |need to accept before they | |can place an article | |request (similar to the | |ILLModuleCopyrightClearance | |system preference). | | | |Add | |the text required to the | |new system preference | |ArticleRequestsDisclaimerTe | |xt. If there is no text in | |the system preference, then | |no message is displayed. | | | |, CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Agustin, we have started moving the HTML system preferences into the news system as this allows to have translated versions of the text. i know this was modeled after the ILLModuleCopyrightClearance that hasn't been moved yet, but would you consider following the new pattern here? opacheader would be an example. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121505|0 |1 is obsolete| | Attachment #121506|0 |1 is obsolete| | Attachment #121507|0 |1 is obsolete| | --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 122053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122053&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|include text that patrons |include text that patrons |need to accept before they |need to accept before they |can place an article |can place an article |request (similar to the |request (similar to the |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance |system preference). |system preference). | | |Add |Add |the text required to the |the text required to the |new system preference |new |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe |xt. If there is no text in |xt entry in the news tool. |the system preference, then | |no message is displayed. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword "action" not allowed while "strict subs" in use at /usr/share/koha/opac/opac-request-article.pl line 49. How did you test that, Agustin? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122053|0 |1 is obsolete| | --- Comment #11 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 122132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122132&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122132|0 |1 is obsolete| | --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 122134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122134&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #14 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Marcel de Rooy from comment #10)

Why not use a construction like:

[% PROCESS koha_news_block news => KohaNews.get({ location => 'ArticleRequestsDisclaimerText', lang => lang, library => branchcode, blocktitle => 0 }) %]

This is used in other places too to insert text block from news.

Basically that construction does not allow for you to have a default language. If you add a disclaimer in english, but you do not have it in other languages, users with english lang will see the disclaimer text, but other users will not. With the construction I coded, it first checks for a disclaimer text in the language of the template, and if not found, uses english as default. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #16)

Please note the fallback in NewsChannels too:

(opac_news.lang = '' OR opac_news.lang = ?)

But it is not very useful here ;) I agree with Katrin that a fallback in cases like this would be nice, but it is not the scope of this report. Given how Koha now operates, I think we could well do without the fallback for now. If you did not define the disclaimer in a language that you do offer, you dont have a disclaimer. As soon as a solution for GetNewsToDisplay is found, it will resolve this case too.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #19 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Katrin Fischer from comment #18)

...

Given how Koha now operates, I think we could well do without the fallback for now. If you did not define the disclaimer in a language that you do offer, you dont have a disclaimer. As soon as a solution for GetNewsToDisplay is found, it will resolve this case too..

+1

Ok, seems I overdid here.. I'll try to keep it simple then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122134|0 |1 is obsolete| | --- Comment #20 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 122519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122519&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122520|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122524&action=edit Bug 27948: (follow-up) Use Koha.news and PROCESS koha_news_block to bring disclaimer Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Actually, seeing a minor bug: +[% SET disclaimer = KohaNews.get( location => "ArticleRequestsDisclaimerText", lang => lang, library => branchcode ) %] Just as I did, you expected branchcode here already filled just like lang is. But unfortunately branchcode is empty. Which results in getting the All branches disclaimer only. I dont consider this as a blocker here, and I suspect that a few other calls of KohaNews.get suffer from the same assumption. So we should probably fill branchcode in Auth.pm like lang in Templates. Opening a new report for this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28650 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #25)

I dont consider this as a blocker here, and I suspect that a few other calls of KohaNews.get suffer from the same assumption. So we should probably fill branchcode in Auth.pm like lang in Templates. Opening a new report for this.

See bug 28650 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #29 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Marcel de Rooy from comment #28)

Agustin: When you have an All branches and a branch specific one, they are both listed directly following each other. An OPAC user would not know that they actually are two separate messages. Staff should be aware of that in order to prevent misunderstandings. No blocker.

I see.. maybe we could make a "KohaNews.getOne" helper with the same paremeters, but get the most relevant news.. if you get one that matches your library it fetches that, else the one for all branches. What do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Passed QA |Patch doesn't apply --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sorry but this does no longer apply. Bug 22544 has been pushed right after this bug has been PQAed and it removed C4::NewsChannels. You shouldn't need the 2 GetNewsToDisplay calls, Koha::News->search_for_display is supposed to deal with that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122771&action=edit Bug 27948: (QA follow-up) Remove NewsChannels reference We only need to remove the obsolete module here. Note that the two NewsToDisplay calls were removed already. Replaced by a KohaNews.get call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- opac/opac-request-article.pl changed file mode from 100755 to 100644 Hum?? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|include text that patrons |include text that patrons |need to accept before they |need to accept before they |can place an article |can place an article |request (similar to the |request (similar to the |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance |system preference). |system preference). | | |Add |Add |the text required to the |the text required to the |new |new |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe |xt entry in the news tool. |xt entry in the additional | |contents tool. -- You are receiving this mail because: You are watching all bug changes.