https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30757 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Nick or Tomas, Do you know if this is actually used somewhere? Koha::ExternalContent and friends (for Overdrive or RecordedBooks). The design of all this is a bit curious to me. This unit test Koha_ExternalContent_RecordedBooks.t makes not much sense imo. We are normally only use_ok ing the module Koha::ExternalContent::RecordedBooks here since the ENV vars will be empty. We could miss that test ;) And skipping two other tests: $user_agent_string =~ m/^Koha/ This is filled in ExternalContent.pm and will not be a surprise. And: ok( $client->search({ query => 'school' }), 'search' ) Actually we are testing external connectivity here? The result does not seem to matter much? We should not rely on external connectivity. And dont need to test the (external) underlying Webservice::ILS stuff. You could make a simple mock object for it? Any reasons to keep this test in its current form ? -- You are receiving this mail because: You are watching all bug changes.