[Bug 13084] New: Mixup of columns in deletedborrowers (from older Koha version)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Bug ID: 13084 Summary: Mixup of columns in deletedborrowers (from older Koha version) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In a 3.14.X database I discover some kind of shift between columns and values. For instance, branchcode was saved in the B_phone field, etc. I tested in current master (3.17.00.27), but could *happily* not reproduce. The problem can date from before 3.14 though. Just saving for the record. If more people have this problem, it might be interesting to see if we can repair the damage ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- UPDATE: This problem still occurs in 3.14.4 (at least). Does anyone know which patch addressed this problem, if any? Will send a 3.14.X patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mixup of columns in |Mixup of columns in |deletedborrowers (from |deletedborrowers (still in |older Koha version) |3.14) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32343&action=edit Bug 13084: Mixup of columns in deletedborrowers (3.14 version) I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. NOTE: The callers of this routine should use the return value to check, and not simply assume that it will be fine ;) Changing those places is out of the scope of this report. Test plan: Edit a borrower. Fill all fields if possible. Delete the borrower. Check that the table deletedborrower contains the data in the correct fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32344&action=edit Bug 13084: Mixup of columns in deletedborrowers (MASTER) I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. Test plan: Edit a borrower. Fill all fields if possible. Delete the borrower. Check that the table deletedborrower contains the data in the correct fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Original patch seems to apply on both versions, but for completeness I added them both. Signoff on master (at least) would be appreciated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|3.14 |master Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mixup of columns in |Prevent mixup of columns in |deletedborrowers (still in |deletedborrowers |3.14) | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Where is the appropriate test to confirm the library function still works as before? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32378&action=edit Bug 13084 - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- By the way, I only think the mix ups occur if your deletedborrowers and borrowers have the fields in different order. Mine were identical. I tested my tests on a plain master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32379&action=edit Bug 13084 - Improve t/db_dependent/Members.t test coverage (3.14 Version) Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32343|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32380&action=edit [SIGNED OFF] Bug 13084: Mixup of columns in deletedborrowers (3.14 version) I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. NOTE: The callers of this routine should use the return value to check, and not simply assume that it will be fine ;) Changing those places is out of the scope of this report. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32344|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32381&action=edit [SIGNED OFF] Bug 13084: Mixup of columns in deletedborrowers (MASTER) I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32378|0 |1 is obsolete| | Attachment #32381|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32394&action=edit Bug 13084 - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32395&action=edit Bug 13084: Mixup of columns in deletedborrowers (MASTER) I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. Tompsett from comment #7)
By the way, I only think the mix ups occur if your deletedborrowers and borrowers have the fields in different order. Mine were identical. I tested my tests on a plain master.
I compared the order of my 3.14 tables and had two differences: | smsalertnumber | varchar(50) | YES | | NULL | | | privacy | int(11) | YES | | NULL | | In deletedborrowers they were in the middle, in borrowers at the end. I looked at kohastructure, but that is fine. I looked in updatedatabase, and it also does not explain this phenomenon.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32379|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32396&action=edit Bug 13084 - Improve t/db_dependent/Members.t test coverage (3.14 Version) Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32397&action=edit Bug 13084: Mixup of columns in deletedborrowers (3.14 version) I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. NOTE: The callers of this routine should use the return value to check, and not simply assume that it will be fine ;) Changing those places is out of the scope of this report. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32394|0 |1 is obsolete| | Attachment #32395|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32490&action=edit Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32491&action=edit Bug 13084 [Master] - Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32492&action=edit Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32490|0 |1 is obsolete| | Attachment #32491|0 |1 is obsolete| | Attachment #32492|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32493&action=edit [PASSED QA] Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32494&action=edit [PASSED QA] Bug 13084 [Master] - Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32495&action=edit [PASSED QA] Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32396|0 |1 is obsolete| | Attachment #32397|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32496&action=edit [PASSED QA] Bug 13084 [3.14.x] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32497&action=edit [PASSED QA] Bug 13084 [3.14.x]: Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. NOTE: The callers of this routine should use the return value to check, and not simply assume that it will be fine ;) Changing those places is out of the scope of this report. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- RM Note: My QA followup does change the implementation of MoveMemberToDeleted completely. This new implementation is much simpler and passes the provided unit tests. However, if you feel it should be re-qa'ed, please reset the status to signed off. This followup has not been included in the 3.14.x patch set, as 3.14 has a bug where unit tests involving DBIC code will fail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32493|0 |1 is obsolete| | Attachment #32494|0 |1 is obsolete| | Attachment #32495|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32500&action=edit Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN --------- 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32501&action=edit Bug 13084 [Master] - Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN --------- 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32502&action=edit Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 32502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32502 Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic This patch breaks misc/cronjob/delete_patrons.pl on debian squeeze, and maybe other things. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13610 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- RMaints, be care, don't backport this! Or at least without the last patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org