https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found what I was thinking about: Bug 12571 - Add ability to customize SIP2 screen messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Katrin Upon discussion with Chris, we've decided to do something different with this and a bit more similar to Bug 12571. Instead of having sysprefs that turn the messages off and on, we'll have sysprefs with text areas so librarians can put their own messages in, leave the default ones, or have them completely empty. This will be good for translation purposes and libraries can use messages in their own languages and means they don't need access to config files etc. Will attach patch when ready -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69809&action=edit Bug 19787: Add sysprefs to hide SIP screen messages in self checkout You'll need two patrons set up for testing the functionality of the patch. I have only created messages for the check out transaction as this was the main request. The remaining transactions can be dealt with in follow-ups. Test plan: Apply patch Update database Create your SIP librarian user Restart SIP server Go to Administration -> Preferences -> SIP Confirm that all system preferences for SIP messages are filled with default messages RenewItemSIPMessage Check out an item to Patron1 using SIP and confirm the 'Item already checked out to you: renewing item.' message shows Change the RenewItemSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately, but the item is still renewed as expected. CheckedToAnotherSIPMessage Check out an item to Patron2 in the intranet Check the same item out to Patron1 using SIP and confirm the 'Item already checked out to another person.' message shows Change the CheckedToAnotherSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out Patron1, it should stay checked out to Patron2, as expected. ReservedSIPMessage Reserve an item to Patron2 in the intranet Check out the same item to Patron1 using SIP and confirm the 'Item is reserved for another patron upon return.' message shows Change the ReservedSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out to Patron1, it should stay reserved for Patron2, as expected. DebtSIPMessage Create a manual invoice for Patron1 to add some fines to their account Check out an item to Patron1 using SIP and confirm the 'Outstanding fines, block issue.' message shows Change the DebtSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out to Patron1 and their fines should not change. ReservedWaitingSIPMessage I've made this syspref but unfortunately couldn't work out where to put it as I couldn't trigger the message. I've put it where it makes sense to go (where all the other sysprefs are) but at this point, no message shows when I do the following: Reserve an item to Patron1 in the intranet Check out the item to Patron1 using SIP - I can't see a message here. Corresponding syspref is ReservedWaitingSIPMessage. HighHoldsSIPMessage Enable the decreaseLoanHighHolds syspref and any other info you need for testing. (I had 5 days for items with more than 1 hold on the record). Reserve an item to Patron1 on the intranet. Reserve the same item to Patron2 on the intranet. Check out the item to Patron1 using SIP and confirm the 'Loan period reduced for high-demand item' message shows Change the HighHoldsSIPMessage syspref to another message, or leave it empty Redo both reserves (ensure in the correct priority order) and check out the item again. Confirm the message has changed appropriately. The item should be checked out and the hold for that patron removed, as expected. Sponsored-by: Whanganui District Council -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding system preferences |Adding system preferences |to disable the screen |to configure the screen |messages for SIP flags in |messages for SIP checkout |Self-Checkout |flags in Self-Checkout -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69809|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 110077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110077&action=edit Bug 19787: Add sysprefs to hide SIP screen messages in self checkout You'll need two patrons set up for testing the functionality of the patch. I have only created messages for the check out transaction as this was the main request. The remaining transactions can be dealt with in follow-ups. Test plan: Apply patch Update database Create your SIP librarian user Restart SIP server Go to Administration -> Preferences -> SIP Confirm that all system preferences for SIP messages are filled with default messages RenewItemSIPMessage Check out an item to Patron1 using SIP and confirm the 'Item already checked out to you: renewing item.' message shows Change the RenewItemSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately, but the item is still renewed as expected. CheckedToAnotherSIPMessage Check out an item to Patron2 in the intranet Check the same item out to Patron1 using SIP and confirm the 'Item already checked out to another person.' message shows Change the CheckedToAnotherSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out Patron1, it should stay checked out to Patron2, as expected. ReservedSIPMessage Reserve an item to Patron2 in the intranet Check out the same item to Patron1 using SIP and confirm the 'Item is reserved for another patron upon return.' message shows Change the ReservedSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out to Patron1, it should stay reserved for Patron2, as expected. DebtSIPMessage Create a manual invoice for Patron1 to add some fines to their account Check out an item to Patron1 using SIP and confirm the 'Outstanding fines, block issue.' message shows Change the DebtSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out to Patron1 and their fines should not change. ReservedWaitingSIPMessage I've made this syspref but unfortunately couldn't work out where to put it as I couldn't trigger the message. I've put it where it makes sense to go (where all the other sysprefs are) but at this point, no message shows when I do the following: Reserve an item to Patron1 in the intranet Check out the item to Patron1 using SIP - I can't see a message here. Corresponding syspref is ReservedWaitingSIPMessage. HighHoldsSIPMessage Enable the decreaseLoanHighHolds syspref and any other info you need for testing. (I had 5 days for items with more than 1 hold on the record). Reserve an item to Patron1 on the intranet. Reserve the same item to Patron2 on the intranet. Check out the item to Patron1 using SIP and confirm the 'Loan period reduced for high-demand item' message shows Change the HighHoldsSIPMessage syspref to another message, or leave it empty Redo both reserves (ensure in the correct priority order) and check out the item again. Confirm the message has changed appropriately. The item should be checked out and the hold for that patron removed, as expected. Sponsored-by: Whanganui District Council -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This enhancement adds released in| |several new system | |preferences so that library | |can define custom SIP | |messages when a patron is | |using self-checkout: | |RenewItemSIPMessage, | |ReservedSIPMessage, | |ReservedWaitingSIPMessage, | |CheckedToAnotherSIPMessage, | |DebtSIPMessage, and | |HighHoldsSIPMessage. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This enhancement adds | released in|several new system | |preferences so that the | |library can define custom | |SIP messages to be | |displayed when a patron is | |using self-checkout: | |RenewItemSIPMessage, | |ReservedSIPMessage, | |ReservedWaitingSIPMessage, | |CheckedToAnotherSIPMessage, | |DebtSIPMessage, and | |HighHoldsSIPMessage. | Text to go in the| |This enhancement adds release notes| |several new system | |preferences so that the | |library can define custom | |SIP messages to be | |displayed when a patron is | |using self-checkout: | |RenewItemSIPMessage, | |ReservedSIPMessage, | |ReservedWaitingSIPMessage, | |CheckedToAnotherSIPMessage, | |DebtSIPMessage, and | |HighHoldsSIPMessage. CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I rebased this to test.. and have a couple of thoughts. 1. You've missed a few cases.. perhaps they were introduced since you wrote the patch.. or perhaps you weren't intending to catch all strings? 2. I'm not seeing any special handling for the existing functionality added with bug 12571... I'm not even sure how you'd go about it. The first point is minor and easily resolve, but I'm a little more worried about the second. As far as I understand, the find and replace based overrides in bug 12571 work at the SIPServer login level.. this means you can override the messages differently for different terminals.. however with your patch, it would be very easy for staff to inadvertently break these per-login value's if they changed away from the defaults at the syspref level. CCing a few people to ascertain whether this is actually a problem or not... If it's not something that needs defining at a login level then I'd be inclined to replace that functionality entirely with this patchset. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Signed off.. as it works as described.. but please bear in mind the caveats above at QA time. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- I would *much* rather see SIP config options to control this behavior rather then sysprefs. At this point it time, sysprefs for SIP behavior are pretty much nonexistant where conf file settings are common. The primary driver is that you may want to hide AFs for one service, but need them displayed for a different service ( self-check vs overdrive for example ). -- You are receiving this mail because: You are watching all bug changes.