https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117406&action=edit Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl The job reports errors when deleting items. The issue seems to be that Koha::Object->delete claims in the POD to return -1, 0, or 1 as a result, but it in fact returns the Object itself on a successful deletion The errors are reported as: ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) To recreate: 1 - Find or create a record with some items 2 - Ensure those items can be deleted (not on loan, etc.) 3 - Edit the record leader and set position 5 to 'd' 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 5 - Deletion succeeds, but reports failure on items 6 - Apply patch 7 - Find or create a new record as above, but this time add an additional item and check it out to a patron 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v 9 - Test mode should report 1 item to be deleted, one with error 10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 11 - One item should be deleted, one item not, record not deleted 12 - check the item in 13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 14 - Successful deletion with no error reported -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117406|0 |1 is obsolete| | Attachment #117407|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119631&action=edit Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl The job reports errors when deleting items. The issue seems to be that Koha::Object->delete claims in the POD to return -1, 0, or 1 as a result, but it in fact returns the Object itself on a successful deletion The errors are reported as: ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) To recreate: 1 - Find or create a record with some items 2 - Ensure those items can be deleted (not on loan, etc.) 3 - Edit the record leader and set position 5 to 'd' 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 5 - Deletion succeeds, but reports failure on items 6 - Apply patch 7 - Find or create a new record as above, but this time add an additional item and check it out to a patron 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v 9 - Test mode should report 1 item to be deleted, one with error 10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 11 - One item should be deleted, one item not, record not deleted 12 - check the item in 13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 14 - Successful deletion with no error reported Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119631|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120232&action=edit Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl The job reports errors when deleting items. The issue seems to be that Koha::Object->delete claims in the POD to return -1, 0, or 1 as a result, but it in fact returns the Object itself on a successful deletion The errors are reported as: ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) To recreate: 1 - Find or create a record with some items 2 - Ensure those items can be deleted (not on loan, etc.) 3 - Edit the record leader and set position 5 to 'd' 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 5 - Deletion succeeds, but reports failure on items 6 - Apply patch 7 - Find or create a new record as above, but this time add an additional item and check it out to a patron 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v 9 - Test mode should report 1 item to be deleted, one with error 10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 11 - One item should be deleted, one item not, record not deleted 12 - check the item in 13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 14 - Successful deletion with no error reported Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected.. always nice to quieten things down bit. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.