[Bug 17845] New: Remove printer related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Bug ID: 17845 Summary: Remove printer related code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org It seems that we want to keep this code, just open this bug report for reference. See Bug 8352 - Add automatic printing of 'hold to pull' notices Bug 16764 - Update printers administration page Bug 2045 - Network Printers Setting Does Nothing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 john thomas <raghuram88585@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raghuram88585@gmail.com --- Comment #1 from john thomas <raghuram88585@gmail.com> --- If you run into any hardware issues while checking your printer, you will need to consult your printer manual or contact the printer manufacturer for assistance. Visit this link https://www.brotherprintersupportnumber.com/brother-customer-support/ for solving printer related issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 adam jems <ajgar17374@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajgar17374@gmail.com --- Comment #2 from adam jems <ajgar17374@gmail.com> --- I am trying to troubleshoot a My brother printer error code Catch 22 which requires me to uninstall and then reinstall the drivers as one of the steps. The problem I am running into is that when I try to uninstall the driver I am told that the driver is in use. I stop the print spool service and try again, however, I get the same error code. For more Visit -https://www.printererrorrepair.com/brother-printer-support-phone-number/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am proposins to remove the code until it's needed. At the moment we have a page we need to maintain and keep secure that is not used at all. I think if there was a patch needing that kind if configuration page, it would be easy to bring it back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79008&action=edit Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Got one QA tool error: FAIL circ/returns.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't locate C4/Print.pm in @INC (you may need to install the C4::Print module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) I assume the "POD coverage was greater before" warning is not relevant. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79008|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79553&action=edit Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I think I forgot to submit that - there was one use C4::Print; left. Fixed now, thx for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79553|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79598&action=edit Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Found 3 smalls things: 1. installer/data/mysql/atomicupdate/bug_17845_remove_printers should be a .perl and DROP COLUMN should only be executed if the column exists (column_exists) 2. koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc: <!-- <li><a href="/cgi-bin/koha/admin/printers.pl">Network Printers</a></li> --> Can be removed 3. in circulation.tt: 604 <input type="hidden" name="print" value="maybe" /> Can be removed as well TODO later: rename selectbranchprinter(.pl|.tt) Note: I have checked the set_userenv calls and they are all good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79598|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100396&action=edit Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100397&action=edit Bug 17845: Update atomic update for new format Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100398&action=edit Bug 17845: (QA follow-up) Remove commented line A commented line still refered to the removed page from the admin-menu.inc Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100399&action=edit Bug 17845: (QA follow-up) Remove hidden print input As highlighted by Jonathan, the hidden 'print' form field is no longer read and thus no longer required in the template. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100400&action=edit Bug 17845: Remove some missed references to branchprinter Remove a few last references to branchprinter, mostly from tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work Katrin! It would be great to see this one finished off.. I've added a few followups to fix the missing parts, address QA concerns and bring it up to date.. and as such didn't feel I should PQA as part of it.. Back to you Jonathan (or any other friendly QA person) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100396|0 |1 is obsolete| | Attachment #100397|0 |1 is obsolete| | Attachment #100398|0 |1 is obsolete| | Attachment #100399|0 |1 is obsolete| | Attachment #100400|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100427&action=edit Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100428&action=edit Bug 17845: Update atomic update for new format Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100429&action=edit Bug 17845: (QA follow-up) Remove commented line A commented line still refered to the removed page from the admin-menu.inc Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100430&action=edit Bug 17845: (QA follow-up) Remove hidden print input As highlighted by Jonathan, the hidden 'print' form field is no longer read and thus no longer required in the template. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100431&action=edit Bug 17845: Remove some missed references to branchprinter Remove a few last references to branchprinter, mostly from tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100432&action=edit Bug 17845: Adjust few other occurrences Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100433&action=edit Bug 17845: Remove the column if it exists Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100434&action=edit Bug 17845: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24837 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9)
TODO later: rename selectbranchprinter(.pl|.tt)
I opened bug 24837. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837 [Bug 24837] selectbranchprinter needs to be renamed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx a lot for finishing this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #27 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove printer related code |Printers related code | |should be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 [Bug 29026] Behavior change when an empty barcode field is submitted in circulation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org