[Bug 30224] New: Wrong important field shown in cataloguing validation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Bug ID: 30224 Summary: Wrong important field shown in cataloguing validation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To reproduce: 1. Go to Administration -> MARC bibliographic frameworks 2. Click Actions next to a framework, view MARC structure 3. Edit multiple tags (at least 2) and check the Important checkbox. 4. Go to cataloguing and create a new record using the framework you just edited 5. Don't fill any of the important fields. Click Save to force the validation for the important tags 6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. Note: we're aware of the weird HTML display, this is fixed by Bug 30159. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 131367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131367&action=edit Bug 30224: Show correct important field in cataloguing validation This patch fxes the cataloguing validation messages to show the correct tag, when the whole field is important (not just a subfield). Note: Look at Bug 30159 to fix the formatting of the validation popup. 1. Go to Administration -> MARC bibliographic frameworks 2. Click Actions next to a framework, view MARC structure 3. Edit multiple tags (at least 2) and check the Important checkbox. 4. Go to cataloguing and create a new record using the framework you just edited 5. Don't fill any of the important fields. Click Save to force the validation for the important tags 6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. 7. Apply patch and refresh page 8. Click Save to force validation again. 9. Confirm the correct tag number is now showing for each error message. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |adam.styles@esa.edu.au |ity.org | Change sponsored?|--- |Sponsored Text to go in the| |This patch fxes the release notes| |cataloguing validation | |messages to show the | |correct tag, when the whole | |field is important (not | |just a subfield). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131367|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 133551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133551&action=edit Bug 30224: Show correct important field in cataloguing validation This patch fxes the cataloguing validation messages to show the correct tag, when the whole field is important (not just a subfield). Note: Look at Bug 30159 to fix the formatting of the validation popup. 1. Go to Administration -> MARC bibliographic frameworks 2. Click Actions next to a framework, view MARC structure 3. Edit multiple tags (at least 2) and check the Important checkbox. 4. Go to cataloguing and create a new record using the framework you just edited 5. Don't fill any of the important fields. Click Save to force the validation for the important tags 6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. 7. Apply patch and refresh page 8. Click Save to force validation again. 9. Confirm the correct tag number is now showing for each error message. Sponsored-by: Education Services Australia SCIS Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |28694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133551|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133677&action=edit Bug 30224: Show correct important field in cataloguing validation This patch fxes the cataloguing validation messages to show the correct tag, when the whole field is important (not just a subfield). Note: Look at Bug 30159 to fix the formatting of the validation popup. 1. Go to Administration -> MARC bibliographic frameworks 2. Click Actions next to a framework, view MARC structure 3. Edit multiple tags (at least 2) and check the Important checkbox. 4. Go to cataloguing and create a new record using the framework you just edited 5. Don't fill any of the important fields. Click Save to force the validation for the important tags 6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. 7. Apply patch and refresh page 8. Click Save to force validation again. 9. Confirm the correct tag number is now showing for each error message. Sponsored-by: Education Services Australia SCIS Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org