http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11626&action=edit Proposed fix for the OPAC Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11715|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11986&action=edit Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, datepickers, and slider (in specify due date popup). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12005&action=edit Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12005|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12041&action=edit Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #8)

I checked out all the different jQuery widgets I could find. Everything looks good to me.

looks good to me too, nice patch Owen passing QA... mason@xen1:~/g/head$ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit c8ef17e) * 5f72a63 Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.js * ccf406f Bug 8644 [staff client] jQueryUI CSS file should not contain customizations koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master, could not find anything wrong (except, maybe the fact that staff-global.css is now 2459 lines long, and would take a lot of benefit from being cleaned. But that's another topic ;-) -- You are receiving this mail because: You are watching all bug changes.