[Bug 28208] New: ModItemTransfer no longer updates item.datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Bug ID: 28208 Summary: ModItemTransfer no longer updates item.datelastseen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 24446 removed a call to ModDateLastSeen - we should blank the datelastseen before storing to update the field - or do we not need to update when calling ModItemTransfer? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- ModItemTransfer is about to be removed ;). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Coming back to this... are you sure Nick? Inside ModItemTransfer we now call the Koha::Item->request_transfer method followed by the Koha::Item::Transfer->transit method (if the item is not checked out) to immediately put it into transit. The transit method calls 'ModDateLastSeen' internally, so this should be getting caught there and updated as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What if the item is checked out? (before was bug 24446 date last seen was updated) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #3)
What if the item is checked out? (before was bug 24446 date last seen was updated)
Correct.. but it's by design. If the item is checked out when a transfer is requested upon it.. then the item hasn't actually been seen has it ;) Pretty sure I actually discussed this at the time.. perhaps I missed someone relevant. Nick, what is the use case/bug resulting from this change? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #4)
(In reply to Jonathan Druart from comment #3)
What if the item is checked out? (before was bug 24446 date last seen was updated)
Correct.. but it's by design. If the item is checked out when a transfer is requested upon it.. then the item hasn't actually been seen has it ;) Pretty sure I actually discussed this at the time.. perhaps I missed someone relevant.
Nick, what is the use case/bug resulting from this change
I filed this simply because I noticed the change, I haven't heard any reports, but I wanted to confirm the change was intentional -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org