[Bug 43951] New: Patron name should not be a link in the heading of pages about that patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 Bug ID: 43951 Summary: Patron name should not be a link in the heading of pages about that patron Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- Bug 43220 and bug 43866 stopped the patron name and card number being a link in the "Checking out to" headings and legend on the circulation pages. The patron name is still a link in the <h1> of several other patron pages, where the page is already about that patron: - Sent notices (members/notices.pl) - Account (members/boraccount.pl) - Statistics (members/statistics.pl) - Subscription routing lists (members/routing-lists.pl) - API keys (members/apikeys.pl) - Housebound details (members/housebound.pl) - Modify patron / Duplicate patron (members/memberentry.pl) This patch passes no_html = 1 to patron-title.inc in those headings, as is already done in members/moremember.tt and members/member-flags.tt. Breadcrumbs are deliberately left alone: the patron name there remains a link back to the patron's details page. Headings that refer to a different patron than the one being viewed (e.g. in returns.tt or merge-patrons.tt) are also left alone. Proposed guideline (for discussion): link the patron name when it is a pointer to a patron the user is not currently viewing (tables, notes, alerts, breadcrumbs), and render it as plain text when it is the heading or legend of a page that is already about that patron. Test plan: 1. Go to a patron's page and open each of: Notices, Accounting (Account tab), Statistics, API keys, Routing lists (needs serials), Housebound (needs HouseboundModule) and Modify patron. 2. Note the patron name and card number in the page heading are a link to the patron's details page. 3. Apply the patch and reload each page. 4. Confirm the heading is plain text, and that the breadcrumb link to the patron is unchanged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 209926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209926&action=edit Bug 43951: Patron name should not be a link in the heading of pages about that patron Bug 43220 and Bug 43866 made the patron name plain text in the "Checking out to" headings. The name is still a link in the <h1> of several other pages that are already about that patron. Pass no_html = 1 to patron-title.inc in those headings, as is already done in moremember.tt and member-flags.tt. Breadcrumbs keep their link. To test: 1. Go to a patron's page and open each of: Notices, Account, Statistics, API keys, Routing lists, Housebound and Modify patron. 2. Note the patron name and card number in the page heading are a link. 3. Apply the patch and reload each page. 4. Confirm the heading is plain text, and the breadcrumb link to the patron is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209926|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210024&action=edit Bug 43951: Add a no_link parameter to patron-title.inc patron-title.inc can only drop the link to the patron by passing no_html, which also removes the <span> wrappers around each name part (surname, cardnumber, etc.). Local IntranetUserJS and IntranetUserCSS commonly rely on those classes. Add a no_link parameter that only drops the link and keeps the spans, so headings can show the patron as plain text without changing the markup inside them. To test: 1. Apply the patch. Nothing changes yet, as no template passes no_link. 2. Check that patron-title.inc output is unchanged on pages that do not pass no_link, e.g. the patron's Details page and a patron checkout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210025&action=edit Bug 43951: Patron name should not be a link in the heading of pages about that patron Bug 43220 and Bug 43866 made the patron name plain text in the "Checking out to" headings. The name is still a link in the <h1> of several other pages that are already about that patron. Pass no_link = 1 to patron-title.inc in those headings. Breadcrumbs keep their link. To test: 1. Go to a patron's page and open each of: Notices, Account, Statistics, API keys, Routing lists, Housebound and Modify patron. 2. Note the patron name and card number in the page heading are a link. 3. Apply the patch and reload each page. 4. Confirm the heading is plain text, and the breadcrumb link to the patron is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210026&action=edit Bug 43951: Use no_link for the circulation headings Bug 43220 and Bug 43866 made the patron name plain text in the "Checking out to" headings by passing no_html, which also removed the <span> wrappers around each name part. Use no_link instead so the name is still plain text but the markup is unchanged from before those bugs. The circ-menu sidebar heading, which was changed to plain text by Bug 42322, is switched in the same way. To test: 1. Check out to a patron: the "Checking out to" label above the barcode input is plain text, and its name parts are wrapped in <span class="surname"> etc. 2. Check out to a patron who cannot check out (e.g. restricted): the "Checking out to" heading is plain text. 3. Go to Circulation > Batch check out and select a patron: the "Checking out to" legend is plain text. 4. Confirm the patron name in the sidebar heading is plain text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210024|0 |1 is obsolete| | Attachment #210025|0 |1 is obsolete| | Attachment #210026|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210027&action=edit Bug 43951: Add a no_link parameter to patron-title.inc patron-title.inc can only drop the link to the patron by passing no_html, which also removes the <span> wrappers around each name part (surname, cardnumber, etc.). Local IntranetUserJS and IntranetUserCSS commonly rely on those classes. Add a no_link parameter that only drops the link and keeps the spans, so headings can show the patron as plain text without changing the markup inside them. To test: 1. Apply the patch. Nothing changes yet, as no template passes no_link. 2. Check that patron-title.inc output is unchanged on pages that do not pass no_link, e.g. the patron's Details page and a patron checkout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210028&action=edit Bug 43951: Patron name should not be a link in the heading of pages about that patron Bug 43220 and Bug 43866 made the patron name plain text in the "Checking out to" headings. The name is still a link in the <h1> of several other pages that are already about that patron. Pass no_link = 1 to patron-title.inc in those headings. Breadcrumbs keep their link. To test: 1. Go to a patron's page and open each of: Notices, Account, Statistics, API keys, Routing lists, Housebound and Modify patron. 2. Note the patron name and card number in the page heading are a link. 3. Apply the patch and reload each page. 4. Confirm the heading is plain text, and the breadcrumb link to the patron is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210029&action=edit Bug 43951: Use no_link for the circulation headings Bug 43220 and Bug 43866 made the patron name plain text in the "Checking out to" headings by passing no_html, which also removed the <span> wrappers around each name part. Use no_link instead so the name is still plain text but the markup is unchanged from before those bugs. The circ-menu sidebar heading, which was changed to plain text by Bug 42322, is switched in the same way. To test: 1. Check out to a patron: the "Checking out to" label above the barcode input is plain text, and its name parts are wrapped in <span class="surname"> etc. 2. Check out to a patron who cannot check out (e.g. restricted): the "Checking out to" heading is plain text. 3. Go to Circulation > Batch check out and select a patron: the "Checking out to" legend is plain text. 4. Confirm the patron name in the sidebar heading is plain text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210030&action=edit Bug 43951: Use no_link for the moremember and member-flags headings The <h1> of the patron details page and of the permissions page already show the patron as plain text, but do so with no_html, which also drops the <span> wrappers around each name part. Use no_link, as in the other patron headings, so the markup is consistent across these pages. To test: 1. Open a patron's Details page: the heading is plain text and its name parts are wrapped in <span class="surname"> etc. 2. Open the patron's Set permissions page: same. 3. Confirm the breadcrumb link to the patron is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Revised patch set: the series now uses a new no_link parameter instead of no_html. The first version passed no_html = 1 to patron-title.inc. That drops the link, but it also removes the <span class="surname">, <span class="cardnumber"> etc. wrappers around each name part. Local IntranetUserJS and IntranetUserCSS often rely on those classes, so hiding them would break local customisations. Patches: 1. Add a no_link parameter to patron-title.inc. It only drops the link and keeps the spans. Output is unchanged for anything that does not pass it. 2. Use no_link in the h1 of the pages that are already about that patron (notices, account, statistics, routing lists, API keys, housebound, modify patron). 3. Switch the circulation headings from Bug 43220 and Bug 43866 (and the circ-menu sidebar heading) from no_html to no_link, so their spans come back and the markup matches what it was before those bugs. 4. Switch the h1 of the patron details page and the permissions page from no_html to no_link, so every patron heading is consistent. Breadcrumbs are unchanged and still link to the patron. no_html is still used where plain text is required, such as <title> and inside links or buttons. Proposed guideline, for discussion: link the patron name when it points to a patron the user is not currently viewing (tables, notes, alerts, breadcrumbs). Show it as plain text, with its spans, in the heading or legend of a page that is already about that patron. I rendered patron-title.inc in KTD to check the three cases. Default output is unchanged, no_link=1 gives the same spans without the <a>, and no_html=1 gives bare text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org