https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36586 [Bug 36586] Self-checkouts will get CSRF errors if left inactive for 8 hours -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- I am suspect of the bug 36586 patch section that reads: [% IF Koha.Preference('SelfCheckReceiptPrompt') %] var confirmStart = Date.now(); confirmModal("", _("Would you like to print a receipt?"), _("Print receipt and end session"), _("End session"), function(result) { - if ( result && (Date.now() - confirmStart) < [% SelfCheckTimeout | html %] ) { + if ( result && (Date.now() - confirmStart) < [% Koha.Preference('SelfCheckTimeout') | html %] ) { var win = window.open("/cgi-bin/koha/sco/printslip.pl?print=qslip"); location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout'; } else { location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout'; } }) - sco_init(); [% ELSE %] location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout'; [% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Christopher, That looks like the right section: Prior to Bug 36586 there was this in the Perl file: $selfchecktimeout = C4::Context->preference('SelfCheckTimeout') * 1000; and then the following check with JS: if ( result && (Date.now() - confirmStart) < [% SelfCheckTimeout | html %] ) { that line was replaced with: if ( result && (Date.now() - confirmStart) < [% Koha.Preference('SelfCheckTimeout') | html %] ) { So now this will not evaluate to true. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183313&action=edit Bug 40158: Multiply scotimeout x 1000 to restore old logic 1. Have SelfCheckReceiptPrompt on 2. Go to the self checkout module 3. Login and press 'Finish' 4. Click 'Print receipt and end session' 5. No print dialogue 6. APPLY PATCH 7. Try again, it should behave as excepeted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- The patch looks like it does restore the old logic, but do we actually need the logic at all? I'll try with this patch and without that datetime handling at all. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works as described. Thanks for fixing this so quickly!!!!! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Christopher and Lucas, could you try out my alternate patch? If there is some quirk to it that I can't see, I'm happy to go with Lucas's patch. But overall I don't see a point in having the old logic there either. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183315|0 |1 is obsolete| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183332&action=edit Bug 40158: [alternate] Remove unnecessary timeout check on sco slip print This change removes an unnecessary/buggy SelfCheckTimeout check when using SelfCheckReceiptPrompt slip printing. To test: 1. Have SelfCheckReceiptPrompt enabled 2. Go to the self checkout module 3. Login and press 'Finish' 4. Click 'Print receipt and end session' 5. The print screen isn't shown and the user is just logged out 6. APPLY PATCH and refresh the page 7. Login and press 'Finish' then click "Print receipt and end session" 8. You should now see a print screen Notes: Set SelfCheckTimeout to a small value like 10 to see that not choosing an option for the SelfCheckReceiptPrompt will mean you're automatically logged out by the timer. If you do choose "Print receipt and end session", the original window will redirect to the logout endpoint, but it won't completely load until after the print screen is actioned - at least in Chrome. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40158 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183332|0 |1 is obsolete| | --- Comment #12 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 183347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183347&action=edit Bug 40158: [alternate] Remove unnecessary timeout check on sco slip print This change removes an unnecessary/buggy SelfCheckTimeout check when using SelfCheckReceiptPrompt slip printing. To test: 1. Have SelfCheckReceiptPrompt enabled 2. Go to the self checkout module 3. Login and press 'Finish' 4. Click 'Print receipt and end session' 5. The print screen isn't shown and the user is just logged out 6. APPLY PATCH and refresh the page 7. Login and press 'Finish' then click "Print receipt and end session" 8. You should now see a print screen Notes: Set SelfCheckTimeout to a small value like 10 to see that not choosing an option for the SelfCheckReceiptPrompt will mean you're automatically logged out by the timer. If you do choose "Print receipt and end session", the original window will redirect to the logout endpoint, but it won't completely load until after the print screen is actioned - at least in Chrome. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Christopher <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.