[Bug 10017] New: Opac CCSR template do not cope well with right-to-left languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bug ID: 10017 Summary: Opac CCSR template do not cope well with right-to-left languages Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: karamqubsi@gmail.com CC: frederic@tamil.fr This problem was with all koha templates and fixed on the Bug 8061 for Opac Prog and staff client so I will upload a patch to fix this on ccsr :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |karamqubsi@gmail.com |ity.org | --- Comment #1 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17315&action=edit OPAC-CCSR-Right-to-left-css Hi :) This patch will add css file for the Opac cssr and then link this css file in the doc-head-close.inc and will add new image : arrow-left-grey-11x6.png for the opposite direction of the right existing one . The test plan is the same for the oldest patches for opac prog and intranet ... 1- perl translate install ar-Arab 2- set opac to use ccsr 3 see it :) I think now all Koha interfaces support rtl languages thanks for you All . Karam. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8061 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 --- Comment #2 from Karam Qubsi <karamqubsi@gmail.com> --- hello :) This needs signoff is there any problem with the patch ? Thanks for your helps :) Karam -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 17315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17315 OPAC-CCSR-Right-to-left-css I haven't taken a thorough look at this yet, but the "include" looks good. I wonder about the "-moz-box-sizing" property in "form#searchform .input-wrapper" though. I know we use vendor-specific CSS elsewhere (like with gradients), but I think this is something that should probably be avoided as much as possible. Is this something that we're using in the left-to-right CSS? In terms of W3 CSS validation, we should avoid vendor-specific CSS and maybe use something like the CSS3 box-sizing property instead (http://www.w3schools.com/cssref/css3_pr_box-sizing.asp). That said, in terms of providing a somewhat consistent look across more browsers, I wonder if it would be better to use several CSS2 properties instead of one CSS3 property, since CSS3 is still in the process of being taken up... But that's just my 2 cents. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 --- Comment #4 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17491&action=edit Follow up OPAC-CCSR-Right-to-left-css Hi, Many thanks for you David , deleting that property will not effect on the results I did that and test it :) I added it when I was doing some tests and forgot to delete it ... you can see the results on this album: https://www.facebook.com/media/set/?set=a.438764382885102.1073741827.277424449019097&type=1 Thanks again Karam -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 --- Comment #5 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17497&action=edit Follow up handling multi libraries form This Follow up patch will handle multi libraries pref when it sets to "add" and enhance the way lists drop down menu appear Test plan for all patches ( the first one and all follow ups ) : 1- apply the patches ( from the first one and all follow up patches) 2- use 3.10 po files and update it (for the master) " ../misc/translate/ perl translate update ar-Arab " 3- install Arabic from the updated po files "perl translate install ar-Arab " 4- set opac opacthemes pref to ccsr 5- set OpacAddMastheadLibraryPulldown pref to add 6- select the Arabic from the opaclanguages pref 7- set opaclanguagesdisplay to allow 8- go to the opac and choose arabic 9- you will see all the directions from right to left ( as you look at koha on a mirror ;) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17315|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17733&action=edit Bug 8061 OPAC-CCSR-Right-to-left-css This patch will add css file for the Opac cssr link this css file in the doc-head-close.inc and add new image : arrow-left-grey-11x6.png for the opposite direction of the right existing one . the test plan is the same http://bugs.koha-community.org/show_bug.cgi?id=10017 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17491|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17734&action=edit Bug 10017 Follow up OPAC-CCSR-Right-to-left-css This follow up patch will delete the "-moz-box-sizing" property that I was add when I'm doing some tests on the rtl css file and I forgot to delete it many thanks David Cook for your notes deleting that property will not effect on the results Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17497|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17735&action=edit Bug 10017--Follow up handling with the multi libraries pref when sets to add . This Follow up patch will handle multi libraries pref when it sets to "add" and enhance the way lists drop down menu appear Test plan for all patches ( the first one and all follow ups ) : 1- apply the patches ( from the first one and all follow up patches) 2- use 3.10 po files and update it (for the master) " ../misc/translate/ perl translate update ar-Arab " 3- install Arabic from the updated po files "perl translate install ar-Arab " 4- set opac opacthemes pref to ccsr 5- set OpacAddMastheadLibraryPulldown pref to add 6- select the Arabic from the opaclanguages pref 7- set opaclanguagesdisplay to allow 8- go to the opac and choose arabic 9- you will see all the directions from right to left ( as you look at koha on a mirror ;) )) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as decribed. No errors. With all patches applied, we get a pretty RTL interface. Well done! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17733|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17736&action=edit [SIGNED-OFF] Bug 8061 OPAC-CCSR-Right-to-left-css This patch will add css file for the Opac cssr link this css file in the doc-head-close.inc and add new image : arrow-left-grey-11x6.png for the opposite direction of the right existing one . the test plan is the same for the oldest patches for opac prog and intranet ... http://bugs.koha-community.org/show_bug.cgi?id=10017 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17734|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17737&action=edit [SIGNED-OFF] Bug 10017 Follow up OPAC-CCSR-Right-to-left-css This follow up patch will delete the "-moz-box-sizing" property that I was add when I'm doing some tests on the rtl css file and I forgot to delete it many thanks David Cook for your notes deleting that property will not effect on the results Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17735|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17738&action=edit [SIGNED-OFF] Bug 10017--Follow up handling with the multi libraries pref when sets to add . This Follow up patch will handle multi libraries pref when it sets to "add" and enhance the way lists drop down menu appear Test plan for all patches ( the first one and all follow ups ) : 1- apply the patches ( from the first one and all follow up patches) 2- use 3.10 po files and update it (for the master) " ../misc/translate/ perl translate update ar-Arab " 3- install Arabic from the updated po files "perl translate install ar-Arab " 4- set opac opacthemes pref to ccsr 5- set OpacAddMastheadLibraryPulldown pref to add 6- select the Arabic from the opaclanguages pref 7- set opaclanguagesdisplay to allow 8- go to the opac and choose arabic 9- you will see all the directions from right to left ( as you look at koha on a mirror ;) )) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as decribed. No errors. With all patches applied, we get a pretty RTL interface. Well done! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17736|0 |1 is obsolete| | Attachment #17737|0 |1 is obsolete| | Attachment #17738|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17768&action=edit [PASSED QA] Bug 8061 OPAC-CCSR-Right-to-left-css This patch will add css file for the Opac cssr link this css file in the doc-head-close.inc and add new image : arrow-left-grey-11x6.png for the opposite direction of the right existing one. the test plan is the same for the oldest patches for opac prog and intranet ... http://bugs.koha-community.org/show_bug.cgi?id=10017 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment on last patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comment on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17769&action=edit [PASSED QA] Bug 10017 Follow up OPAC-CCSR-Right-to-left-css This follow up patch will delete the "-moz-box-sizing" property that I was add when I'm doing some tests on the rtl css file and I forgot to delete it many thanks David Cook for your notes deleting that property will not effect on the results Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment on last patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comment on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17770&action=edit [PASSED QA] Bug 10017 -Follow up handling with the multi libraries pref active This Follow up patch will handle multi libraries pref when it sets to "add" and enhance the way lists drop down menu appear Test plan for all patches ( the first one and all follow ups ) : 1- apply the patches ( from the first one and all follow up patches) 2- use 3.10 po files and update it (for the master) " ../misc/translate/ perl translate update ar-Arab " 3- install Arabic from the updated po files "perl translate install ar-Arab " 4- set opac opacthemes pref to ccsr 5- set OpacAddMastheadLibraryPulldown pref to add 6- select the Arabic from the opaclanguages pref 7- set opaclanguagesdisplay to allow 8- go to the opac and choose arabic 9- you will see all the directions from right to left (as you look at koha on a mirror ;) )) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as decribed. No errors. With all patches applied, we get a pretty RTL interface. Well done! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changes are mostly CSS, one new image and a tiny template change. Used po files from 3.8 for testing. Looks good! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org