[Bug 26680] New: Highlight (rcvd) in basket view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Bug ID: 26680 Summary: Highlight (rcvd) in basket view Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org Created attachment 111638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111638&action=edit Title in basket with (rcvd) displayed in red When viewing a basket of titles on basket.pl it would helpful to highlight the (rcvd) info for ease of use and efficiency. We currently use some jQuery (created for us by George Williams at NEKLS) to make ours red so that it stands out. But I think it would great if this could be incorporated into Koha. Example: (rcvd) All the devils are here / by Penny, Louise. jQuery we're using: $("#acqui_basket_content p:contains('(rcvd)')").html(function(_, html) { return html.replace(/(rcvd)/g, '<span style="font-weight: bold; color: #990000;">$1</span>'); }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would it already help to wrap the received in a span with a class for easier styling? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Maybe it's also time to change "rcvd" to "received" (for English clarity and ease of translation for non-English users)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #3 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I think wrapping in a span for easier styling would be great. Good suggestion to change the wording to "received" which is more clear and improving ease of translation is a bonus too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111943&action=edit Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Highlight (rcvd) in basket |Update (rcvd) to (received) |view |with its own class in | |basket view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- In the 5th step, when I click on Receive I'm getting the error - "Template process failed: undef error - The method Koha::Item->size is not covered by tests!" which is followed by lots of details about the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Barbara Johnson from comment #5)
In the 5th step, when I click on Receive I'm getting the error - "Template process failed: undef error - The method Koha::Item->size is not covered by tests!" which is followed by lots of details about the error.
Hi Barbara, I wonder if this is related to the patch as I haven't touched the receive process, only the basket summary page. If you can, could you repeat the tests with out the patch? Did you create items on order? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26730 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Receiving items is broken for me too - independent of this patch :( I filed bug 26730. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111943|0 |1 is obsolete| | --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112054&action=edit Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112054|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 112076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112076&action=edit Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112076|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112105&action=edit Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice little enhancement, works well.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27400 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org