[Bug 8216] New: Enable critic tests on SIP modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Priority: P5 - low Change sponsored?: --- Bug ID: 8216 Assignee: colin.campbell@ptfs-europe.com Summary: Enable critic tests on SIP modules Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: unspecified Component: SIP2 Product: Koha Paul remarked in relation to pushing a fix for another bug that SIP modules continued to issue a number of perlcritic warnings. This patch will add C4/SIP to the testcritic diirectories and address those issues which are warnings (mainly return undef and subroutine prototypes) it also removes some dead code that was no longer used. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 10006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10006&action=edit Proposed patch Adds C4/SIP to critic tests To Test set environment variable TEST_QA to 1 from top level ran critic tests: prove t/00-testcritic.t no warnings should be generated -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Stacey Walker <stacey@catalyst-eu.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10006|0 |1 is obsolete| | --- Comment #2 from Stacey Walker <stacey@catalyst-eu.net> --- Created attachment 10092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10092&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Stacey Walker <stacey@catalyst-eu.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stacey@catalyst-eu.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- PBP patch; almost all changes to code are completely functionally equivalent to their old forms, but now conform to guidelines. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Enabling more tests = win, pushed to 3.8.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org