[Bug 25250] New: JS code for checkboxes also affects hidden modules inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Bug ID: 25250 Summary: JS code for checkboxes also affects hidden modules inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org bug 24982 added checkboxes to the log viewer and added js to control them. The JS conflicts with code form 19791 and affects the hidden inputs that limit viewing a patrons circ info when coming from their account (i.e. the Modification log tab on a patron) The JS should be adjusted to only affect the checkboxes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982 [Bug 24982] Use checkboxes in Log Viewer instead of select dropdowns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103478&action=edit Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log If we are coming from the "Modification logs" of the patron module we should not disable the checkboxes (that are not visible). Otherwise the logs are not longer filtered and all are visible. Test plan: 0. Don't apply this patch 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all the logs (KO) 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons only (KO) 7. Apply the patch from bug 25249 8. Click the "Modification logs" => You see the Patrons and Circulation logs 9. Click submit => You see the Patrons and Circulation logs (OK!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25249 [Bug 25249] When viewing a patron's modiification log we should see both the MEMBERS and CIRCULATION modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103479&action=edit Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log If we are coming from the "Modification logs" of the patron module we should not disable the checkboxes (that are not visible). Otherwise the logs are not longer filtered and all are visible. Test plan: 0. Don't apply this patch 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all the logs (KO) 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons only (KO) 7. Apply the patch from bug 25249 8. Click the "Modification logs" => You see the Patrons and Circulation logs 9. Click submit => You see the Patrons and Circulation logs (OK!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103484&action=edit Bug 25250: [alternate] target checkboxes only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103479|0 |1 is obsolete| | Attachment #103484|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103486&action=edit Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log If we are coming from the "Modification logs" of the patron module we should not disable the checkboxes (that are not visible). Otherwise the logs are not longer filtered and all are visible. Test plan: 0. Don't apply this patch 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all the logs (KO) 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons only (KO) 7. Apply the patch from bug 25249 8. Click the "Modification logs" => You see the Patrons and Circulation logs 9. Click submit => You see the Patrons and Circulation logs (OK!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103486|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103487&action=edit Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log If we are coming from the "Modification logs" of the patron module we should not disable the checkboxes (that are not visible). Otherwise the logs are not longer filtered and all are visible. Test plan: 0. Don't apply this patch 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all the logs (KO) 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons only (KO) 7. Apply the patch from bug 25249 8. Click the "Modification logs" => You see the Patrons and Circulation logs 9. Click submit => You see the Patrons and Circulation logs (OK!) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |nick@bywatersolutions.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103487|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103747&action=edit Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log If we are coming from the "Modification logs" of the patron module we should not disable the checkboxes (that are not visible). Otherwise the logs are not longer filtered and all are visible. Test plan: 0. Don't apply this patch 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all the logs (KO) 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons only (KO) 7. Apply the patch from bug 25249 8. Click the "Modification logs" => You see the Patrons and Circulation logs 9. Click submit => You see the Patrons and Circulation logs (OK!) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25250 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies - not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org