[Bug 26831] New: Replace 'list-invites' parameter with system preference in cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Bug ID: 26831 Summary: Replace 'list-invites' parameter with system preference in cleanup_database.pl cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Database Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Depends on: 13701 Currently the cleanup_database.pl cronjob accepts a 'list-invites' parameter. This is the age (in days) at which list share invites are purged from the database. If this parameter is not passed to the cleanup_database.pl cronjob then it defaults to 14. It would be nice to replace this cronjob parameter - which only users with server access can alter - with a system preference. This system preference would have a default value of 14 for new and upgrading Koha installs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24968 CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 112634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112634&action=edit Bug 26831: Add a system preference to define the number of days used for purging unaccepted list share invites in cleanup_database.pl The PurgeUnacceptedListShareInvitesOlderThan system preference value is used whenever the cleanup_database.pl cron job is called without the --list-invites parameter. If neither the system preference or the --list-invites parameter has a value then the cronjob errors out. Test plan: 1. Apply patch 2. Update database: sudo koha-shell <instancename> cd installer/data/mysql ./updatedatabase.pl 3. Confirm the default value of the PurgeUnacceptedListShareInvitesOlderThan system preference is 14 4. Run the cleanup_database.pl script without the --list-invites parameter: sudo koha-shell <instancename> cd misc/cronjobs ./cleanup_database.pl -v 5. Confirm the following text is included in the output: "Purging unaccepted list share invites older than 14 days." 6. Clear the aforementioned system preference. Run the cleanup_database.pl cron job with the --list-invites parameter defined: ./cleanup_database.pl --list-invites 10 -v 7. Confirm the following text is included in the output: "Purging unaccepted list share invites older than 10 days." 8. Input a value of 20 into the aforementioned system preference. Run the cron job with --list-invites defined: ./cleanup_database.pl --list-invites 10 -v 9. Confirm the following text is included in the output: "Purging unaccepted list share invites older than 10 days." 10. Clear the aforementioned system preference value and run the cron job without the --list-invites parameter: ./cleanup_database.pl -v 11. Confirm the following text is included in the output: "You did not specify any cleanup work for the script to do" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin, I've done a bit of investigation and found bug 13287 , and wondered if our approach to the --list-invites parameter in the cleanup_database.pl cron job should change? Looking at that bug, I saw instead of replacing the cron parameter with a system preference, they used both: * If both parameter and syspref are set then prioritise the parameter value * If only syspref is set then use syspref value * If only parameter set then use parameter value * If neither syspref nor parameter value is set then don't do anything If we go with this approach, then at least existing installs can to continue to call the cleanup_database.pl cronjob, with the list-invites parameter, without a change of behaviour. What are your thoughts on this? I thought it good to have a discussion about this, before I start writing the unit tests! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, that makes sense to me. IIUC: Replacing would probably mean that it would stop deleting until libraries set it up again, which could be easily missed for a while. Having both together would leave options and not interrupt on update. The prioritizing of options should be well documented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #3)
Hi Alex, that makes sense to me.
IIUC: Replacing would probably mean that it would stop deleting until libraries set it up again, which could be easily missed for a while. Having both together would leave options and not interrupt on update.
The prioritizing of options should be well documented.
Hi Katrin, Thanks for that, and yes you're absolutely right that is what I am thinking, and agreed prioritizing of options should definitely be well documented to avoid confusion. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140747&action=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140748&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell <instance> cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell <instance. cd misc/cronjobs ./cleanup_database.pl 11. Observe you get the following output (along with documentation on all parameters of the script): "You did not specify any cleanup work for the script to do." 12. Run the cleanup_database with no days defined for the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140749&action=edit Bug 26831: Attempting to clarify priotising of options Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140749|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140750&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140751&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell <instance> cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell <instance. cd misc/cronjobs ./cleanup_database.pl 11. Observe you get the following output (along with documentation on all parameters of the script): "You did not specify any cleanup work for the script to do." 12. Run the cleanup_database with no days defined for the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140752&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Summary|Replace 'list-invites' |Enable librarians to |parameter with system |control when unaccepted |preference in |private list share invites |cleanup_database.pl cronjob |are removed by the | |cleanup_database.pl cronjob Text to go in the| |The new release notes| |PurgeListShareInvitesOlderT | |han system preference | |enables librarians to | |control when unaccepted | |private list share invites | |are removed from the | |database. | | | |Unaccepted | |private list share invites | |will now be removed based | |on the following | |prioritised options: | | | |- | |Priority 1. Use DAYS value | |when the | |cleanup_database.pl cronjob | |is run with a | |--list-invites DAYS | |parameter specified. | | | |- | |Priority 2. Use the | |PurgeListShareInvitesOlderT | |han system preference | |value. | | | |- Priority 3. Use a | |default of 14 days, if the | |cleanup_database.pl cronjob | |is run with a | |--list-invites parameter | |missing the DAYS value, AND | |the | |PurgeListShareInvitesOlderT | |han system preference is | |empty. | | | |- Priority 4. Don't | |remove any unaccepted | |private list share invites | |if the cleanup_database.pl | |cronjob is run without the | |--list-invites parameter | |and the | |PurgeListShareInvitesOlderT | |han syspref is empty. Status|ASSIGNED |Needs Signoff Keywords| |Academy, Manual, | |release-notes-needed --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Ready for testing. Please feel free to update the release notes if you think you can improve by clarifying the prioritising of the options for controlling when unaccepted private list share invites are deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(.. git bz apply 26831 Bug 26831 - Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob 140747 - Bug 26831: Add new system preference PurgeListShareInvitesOlderThan 140751 - Bug 26831: Use new PurgeListShareInvitesOlderThan syspref 140752 - Bug 26831: Attempting to clarify prioritising of options Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 26831: Add new system preference PurgeListShareInvitesOlderThan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 157684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157684&action=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 157685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157685&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell <instance> cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell <instance. cd misc/cronjobs ./cleanup_database.pl 11. Observe you get the following output (along with documentation on all parameters of the script): "You did not specify any cleanup work for the script to do." 12. Run the cleanup_database with no days defined for the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 157686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157686&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #12)
The patches no longer apply 8-(..
git bz apply 26831
Bug 26831 - Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
140747 - Bug 26831: Add new system preference PurgeListShareInvitesOlderThan 140751 - Bug 26831: Use new PurgeListShareInvitesOlderThan syspref 140752 - Bug 26831: Attempting to clarify prioritising of options
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 26831: Add new system preference PurgeListShareInvitesOlderThan
Hi David, Sorry for my delay, I've just back from a long holiday. I hope you are doing well :) I've rebased these patches against master. Ready to test again now. Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157684|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 157711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157711&action=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157685|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 157712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157712&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell <instance> cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell <instance. cd misc/cronjobs ./cleanup_database.pl 11. Observe you get the following output (along with documentation on all parameters of the script): "You did not specify any cleanup work for the script to do." 12. Run the cleanup_database with no days defined for the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157686|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 157713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157713&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 157714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157714&action=edit Bug 26831: (follow-up) Update system preference description Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #21 from David Nind <david@davidnind.com> --- (In reply to Alex Buckley from comment #16)
Hi David,
Sorry for my delay, I've just back from a long holiday. I hope you are doing well :)
I've rebased these patches against master. Ready to test again now.
Alex
Hi Alex. Welcome back! I hope you had a great holiday! (I'm doing well, thanks!) I've now signed off. I've also updated the system preference description, mainly for consistency with other system preferences (such as NOTE in capitals, script name in a code block) as well as some other wording changes. Feel free to remove if you prefer the original description. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #22 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #21)
(In reply to Alex Buckley from comment #16)
Hi David,
Sorry for my delay, I've just back from a long holiday. I hope you are doing well :)
I've rebased these patches against master. Ready to test again now.
Alex
Hi Alex.
Welcome back! I hope you had a great holiday! (I'm doing well, thanks!)
I've now signed off.
I've also updated the system preference description, mainly for consistency with other system preferences (such as NOTE in capitals, script name in a code block) as well as some other wording changes. Feel free to remove if you prefer the original description.
David
Hi David Thanks so much, yes I did have a very nice holiday around Italy with my parents it was lovely. That's great to hear you're doing well :) Thank you for testing and signing off, also appreciate your update to the system preference description that is much better now! Kind regards, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157711|0 |1 is obsolete| | Attachment #157712|0 |1 is obsolete| | Attachment #157713|0 |1 is obsolete| | Attachment #157714|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159097&action=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159098&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell <instance> cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell <instance. cd misc/cronjobs ./cleanup_database.pl 11. Observe you get the following output (along with documentation on all parameters of the script): "You did not specify any cleanup work for the script to do." 12. Run the cleanup_database with no days defined for the --list-invites parameter: sudo koha-shell <instance> cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159099&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159100&action=edit Bug 26831: (follow-up) Update system preference description Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159101&action=edit Bug 26831: (follow-up) Tidy code for qa script Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159102&action=edit Bug 26831: (follow-up) Tidy cleanup_database.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like seeing us move settings like this into the system preference/GUI. It makes it much easier to manage different settings for servers with multiple instances. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35893 [Bug 35893] Missing closing </li> in opac.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- 23.11.03 is still young, I choose to backport the enhancement :) Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement, no backport for 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, robin@catalyst.net.nz Component|Database |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The new |The new release notes|PurgeListShareInvitesOlderT |`PurgeListShareInvitesOlder |han system preference |Than` system preference |enables librarians to |enables librarians to |control when unaccepted |control when unaccepted |private list share invites |private list share invites |are removed from the |are removed from the |database. |database. | | |Unaccepted |Unaccepted |private list share invites |private list share invites |will now be removed based |will now be removed based |on the following |on the following |prioritised options: |prioritised options: | | |- |- |Priority 1. Use DAYS value |Priority 1. Use DAYS value |when the |when the |cleanup_database.pl cronjob |cleanup_database.pl cronjob |is run with a |is run with a |--list-invites DAYS |--list-invites DAYS |parameter specified. |parameter specified. | | |- |- |Priority 2. Use the |Priority 2. Use the |PurgeListShareInvitesOlderT |PurgeListShareInvitesOlderT |han system preference |han system preference |value. |value. | | |- Priority 3. Use a |- Priority 3. Use a |default of 14 days, if the |default of 14 days, if the |cleanup_database.pl cronjob |cleanup_database.pl cronjob |is run with a |is run with a |--list-invites parameter |--list-invites parameter |missing the DAYS value, AND |missing the DAYS value, AND |the |the |PurgeListShareInvitesOlderT |PurgeListShareInvitesOlderT |han system preference is |han system preference is |empty. |empty. | | |- Priority 4. Don't |- Priority 4. Don't |remove any unaccepted |remove any unaccepted |private list share invites |private list share invites |if the cleanup_database.pl |if the cleanup_database.pl |cronjob is run without the |cronjob is run without the |--list-invites parameter |--list-invites parameter |and the |and the |PurgeListShareInvitesOlderT |PurgeListShareInvitesOlderT |han syspref is empty. |han syspref is empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/929 Keywords|Academy, Manual, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org