https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 Brandon <brandon@wwcrld.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brandon@wwcrld.org --- Comment #2 from Brandon <brandon@wwcrld.org> --- +1 for this feature. Phone number fields should not be plain text inputs. Just a recipe for bad data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Brandon from comment #2)

+1 for this feature. Phone number fields should not be plain text inputs. Just a recipe for bad data.

The correct way to do this is probably Bug 23817, normalize all phone numbers in patron search and DB. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #4)

Funny enough I was just talking last night about how I should resurrect this for main. I've been using it locally for the past 2 years and it's nice.

Let me know if you'd like me to post some updated patches. I could certainly make some time for that, if you're interested in it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- David has a much better way of doing this in Bug 23817. *** This bug has been marked as a duplicate of bug 23817 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196897&action=edit Bug 39882: Add new system preferences Patch from commit 8e64c59 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196899&action=edit Bug 39882: Corrections to DB update Patch from commit 8bff147 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196897|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 196901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196901&action=edit Bug 39882: Add ability to mask phone numbers on memberentry.pl To test: 1. APPLY PATCH, restart_all, updatedatabase 2. Seach for the 2 new system preferences PhoneMaskPattern and PhoneMaskFields 3. The 2 prefs should be linked to each other, searching for one should bring up the other. 4. Look at the "Examples" in the system pref description, make sure they make sense. 5. Pick one of the pattern examples, or come up with your own. Add it to PhoneMaskPattern. 6. For PhoneMaskFields, start by selecting all and saving. 7. Now go to Patrons > New patron 8. In each of the phone number fields try entering a phone number, make sure the mask is working correctly. 9. Save the patron and edit them, make sure the phone masking works well on each field when you are editing it. 10. Go back to PhoneMaskFields and turn some of the fields off. 11. Go back to patron editing and make sure that those field from step 10 do NOT apply a mask. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #15 from David Nind <david@davidnind.com> --- I've signed off, but a couple of comments: 1. The options for PhoneMaskFields don't match what is on the patron add and edit form: - Labels on the form: . Contact information: . Primary phone . Secondary phone . Other phone . Alternate address: . Phone . Alternate contact: . Phone . Patron messaging preferences: . SMS number (has hint: Please enter numbers only. Prefix the number with + or 00 if including the country code.) - Options for PhoneMaskFields: . [Select all] . Alternate address phone (can match) . Alternate contact phone (can match) . Mobile* . Phone* . SMS number (can match) . Work phone* 2. I personally found it confusing that there is no indicator or anything on the field to indicate that you should enter it a particular way. 3. Accessibility and other issues: - Is there any reason we don't use the "tel" input type? https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/t... - I'm not up with the play about creating accessible telephone number input fields, but a quick search resulted in: . Use autocomplete: autocomplete="tel" (may not be relevant here as patrons aren't completing) . Use placeholder/help text - UK design system information for phone numbers: https://design-system.service.gov.uk/patterns/phone-numbers/ - In the absence of a Koha design system, should we just follow the UK or Canadian design system guidelines? (A bigger issue than this on though) 4. I know that this or related issues have been debated for a while now (including the related bugs), so don't want to hold an improvement up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39882 --- Comment #17 from David Nind <david@davidnind.com> --- (In reply to Michael Adamyk from comment #16)

David, would an enhancement like bug 41636 address your point in #2, about the indication of how to enter numbers in a particular way? Though it's specifically about the SMS number text.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41636

Having some way to add hint text so you know what is required would be good. -- You are receiving this mail because: You are watching all bug changes.