[Bug 38747] New: Have consistent signature in sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38747 Bug ID: 38747 Summary: Have consistent signature in sample notices Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org We currently have a plethora of signature styles across sample notices. It would be nice to make them consistent. Here are the ones I found in the sample_notices.yaml file (I skipped the slips and sms messages) Notices meant for patrons - branchname Staff (ODUE) - Kind regards<br>branchname (BOOKING_CANCELLATION, BOOKING_MODIFICATION, BOOKING_CONFIRMATION) - Kind regards<br>full branch address (ILL_PICKUP_READY, ILL_REQUEST_UNAVAIL, ILL_REQUEST_UPDATE, ILL_PICKUP_READY, ILL_REQUEST_UNAVAIL) - Thank you (TICKET_ACKNOWLEDGE, TICKET_RESOLVE, TRANSFER_OWNERSHIP) - Thank you,<br>branchname (ACCEPTED, AVAILABLE, ORDERED, REJECTED) - Thank you,<br>Librarian<br>branchname (MEMBERSHIP_EXPIRY) - Thank you,<br>Your library,<br>branchname (MEMBERSHIP_RENEWED) - Thank you. (CHECKIN, DUEDGST, PREDUEDGST, PASSWORD_RESET,STAFF_PASSWORD_RESET) - Thank you.<br>Your library. (SHARE_ACCEPT, SHARE_INVITE) - Thank you! (AR_COMPLETED, AR_PENDING, AR_REQUESTED, AR_PROCESSING, HOLDDGST, RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, HOLDPLACED_PATRON) - Thank you for visiting branchname. (CHECKOUT, RENEWAL) - Your library. (ACQ_NOTIF_ON_RECEIV, PASSWORD_CHANGE) - Your library (AR_CANCELED, 2FA_DISABLE) - No signature (ACCOUNT_PAYMENT, ACCOUNT_WRITEOFF, DUE, PREDUE, DISCHARGE,OPAC_REG_VERIFY, WELCOME, 2FA_OTP_TOKEN, CANCEL_HOLD_ON_LOST, HOLD, HOLD_REMINDER, NEW_CURBSIDE_PICKUP, SERIAL_ALERT, AUTO_RENEWALS, AUTO_RENEWALS_DGST, LIST, CART) Notices meant for staff, other libraries, vendors, etc. - Thank you (TICKET_ACKNOWLEDGE, TICKET_RESOLVE) - Thank you,<br>branchname (ACQORDER, TO_PROCESS, NOTIFY_MANAGER) - Kind regards<br>full branch adress (ILL_PARTNER_REQ) - Your library (2FA_DISABLE) - No signature (TICKET_ASSIGNED, TICKET_NOTIFY, CHECKOUT_NOTE, ACQCLAIM, ILL_REQUEST_CANCEL, ILL_REQUEST_MODIFIED, ILL_REQUEST_CANCEL, ILL_REQUEST_MODIFIED, HOLDPLACED, HOLD_CHANGED, NEW_SUGGESTION, PROBLEM_REPORT, OPAC_REG, OAI_HARVEST_REPORT) Is there any that would fit all of them? I like "Thank you,<br>branchname" provided the branch is available for the notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38747 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #1 from Philip Orr <philip.orr@lmscloud.de> --- For sample notices (and for easier translation :) ) it might be good to have it as simple as possible. So not the full address. I like "Thank you,<br>branchname" as well. Or "Kind regards,<br>branchname", I would prefer either of them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38747 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we re-use the address includes we use in other spots for the signature? This way we could also pull the different formats according to the AddressFormat system preference (I18N). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38747 Alexander Wagner <alexander.wagner@desy.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.wagner@desy.de --- Comment #3 from Alexander Wagner <alexander.wagner@desy.de> --- Similar to Katrin I'd also vote for the possibility to move the signature to a separate file and include it somehow, not only for the samples but also for "real life". It's quite a number of notices where it should be added consistently, and it might be quite lengthy as well. This would also help in the translation issues Philip mentions: it's just one file that needs to be translated. If it's possible to include a signature somehow right now did not notice that as I started out with the samples. So for me as a newbe they also serve as a "how they do it in Koha". BTW: I'd also suggest to split off signatures from the mail body by the usual marker (`-- ` in it's own line). Including it in a file might also allow to enforce standard conformity by Koha adding it before the signature. (cf. RFC 3676, https://datatracker.ietf.org/doc/html/rfc3676#section-4.3) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38747 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #4 from Lari Taskula <lari.taskula@hypernova.fi> --- The same goes with greetings. Some examples - (no greeting) - "<<borrowers.firstname>> <<borrowers.surname>>," - "Dear <<borrowers.firstname>> <<borrowers.surname>>," - "Dear [% borrower.firstname %] [% borrower.surname %] ([% borrower.cardnumber %])" - "Dear [%- INCLUDE 'patron-title.inc' patron => booking.patron -%],<br>" - "Hello [% borrower.title %] [% borrower.firstname %] [% borrower.surname %].<br>" - "Hello [% borrower.firstname %] [% borrower.surname %] ([% borrower.cardnumber %])," - "Hi,<br><br> I'd separate the signatures and greetings from the notice template bodies and propose adding a configurable greeting/header and a signature/footer as a notice-wide, library-wide and a global setting (in this order, whatever is defined first is selected to the notice). This way libraries could manage the signatures and the greetings without necessarily having to modify all of the notice templates. Library-wide and global settings would have to be configurable by notice language, message transport type and the is_html flag. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38747 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35832, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30723 --- Comment #5 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #4)
I'd separate the signatures and greetings from the notice template bodies and propose adding a configurable greeting/header and a signature/footer
The above was already proposed in Bug 30723. See also Bug 35832. It seems all of the three Bugs at least partially overlap each other. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org