[Bug 26708] New: Add SQL popup when hovering over name of report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Bug ID: 26708 Summary: Add SQL popup when hovering over name of report Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org In Mana, when you hover over the information in the Notes column you get a popup box that shows the SQL code. It would be nice to incorporate this functionality into the list of saved reports in Koha. We don't always have notes information for our reports and the title doesn't always reveal what it is supposed to do. Being able to see the SQL code without having to open it would be helpful. Maybe providing this information in a popup when you hover over the report name would work. Also, this might not be functionality that every library would want so being able to opt in or out would be good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- This is a really good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org --- Comment #2 from Ed Veal <eveal@mckinneytexas.org> --- I agree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|19.11 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115967&action=edit Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the option release notes| |to preview a saved report's | |SQL directly from the list | |of saved reports. From this | |preview the user can edit | |the report, duplicate it, | |schedule it, run it, or | |delete it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115967|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115973&action=edit Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115973|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115974&action=edit Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I really like this popup for previewing the SQL and that it includes all of the different actions right from the popup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if this should not replace the "View" which does the same as the "Preview" now. Is there a reason to keep both? Can you please also adjust the bug description as this has now been solved a little differently than initially suggested? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add SQL popup when hovering |Add option to preview SQL |over name of report |from list of saved reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #7)
I wonder if this should not replace the "View" which does the same as the "Preview" now. Is there a reason to keep both?
I think a static page is always a good option to have--opening the view in a new tab, for instance, for referring to without worrying that the modal will close because of an accidental click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115974|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116473&action=edit Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- In my opinion, this may replace the "View" action -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org