[Bug 24605] New: Series link from 830 is not uri encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Bug ID: 24605 Summary: Series link from 830 is not uri encoded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Missed one on bug 14716 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98539&action=edit Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14716 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, What kind of record is needed? I edited a record to add an 830 field, does not show in the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bernardo, you also need a 490 where the indicator is set to traced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98539|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99509&action=edit Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99553&action=edit Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Same change as the first patch, but for the staff detail page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This was only half the fix - please remember OPAC and staff use different XSLT files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #3)
Hi Bernardo, you also need a 490 where the indicator is set to traced.
Thanks Katrin, I don't know much about MARC, but wanted to test. Questions: * Why we still hide 490 in our frameworks for new installs? * Wouldn't it be better to make both 440 'and' 490 visible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Bernardo Gonzalez Kriegel from comment #7)
(In reply to Katrin Fischer from comment #3)
Hi Bernardo, you also need a 490 where the indicator is set to traced.
Thanks Katrin, I don't know much about MARC, but wanted to test.
Questions: * Why we still hide 490 in our frameworks for new installs? * Wouldn't it be better to make both 440 'and' 490 visible?
Hi Bernardo, you are right: 440 has been succeeded by 490. It would make sense to change the default for new installations to hide 440 and display 490 instead. Or display both (assuming some data still uses 440, although it's been obsoleted) But better on a separate bug - I think there might even be one already somewhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org