[Bug 23412] New: HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Bug ID: 23412 Summary: HTML should be allowed in MARC notes. (5xx fields) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some librarians like to add HTML in the 5xx fields to display links, etc. We should allow $raw filters in this case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 91909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91909&action=edit Bug 23412: HTML should be allowed in MARC notes. (5xx fields) TEST PLAN 1. Add some HTML to one of the 5xx fields that displays in the OPAC: <a href ="www.koha-community.org">koha</a> 2. Go to the record in the OPAC and look under the 'Title notes' tab. 3. See that the HTML displays literally. 4. Apply patch 5. Look at the 'Title notes' tab again. 6. HTML displays correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91909|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91936&action=edit Bug 23412: HTML should be allowed in MARC notes. (5xx fields) Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What about regular use of chars like < and & in a note. Alice & Bob e.g. becomes now Alice $ Bob This might need a bit more thought? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #3)
What about regular use of chars like < and & in a note. Alice & Bob e.g. becomes now Alice $ Bob
This might need a bit more thought?
I've done some testing too, these were my 500$a: <a href ="http://www.koha-community.org">koha</a> http://www.koha-community.org Alice & Bob They all display nicely, with the second already being displayed as a link without the patch(!). So I don't see the breakage Marcel points out. But what breaks is: Berlin <Germany> With the browser hiding the part <Germany>. We often see this in older data as it used to be a common cataloguing practice. There are also other use cases for <> like mathematic formulas that we could break display with this change. Note: this also only changes the OPAC, but not the staff display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I think we should use html_line_break filter like it used to be : to allow HTML and also present simple multi-lines text. Patch must cover staff and basket on MARCNOTES and notes. I'm on a patch and a nice test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21947 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #5)
I think we should use html_line_break filter like it used to be : to allow HTML and also present simple multi-lines text.
Patch must cover staff and basket on MARCNOTES and notes.
I'm on a patch and a nice test plan.
Oups this is an old statement. I have no patch nor test plan. We should also fix staff interface no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am still not sure we should bend the standard like that... especially as it will break things like the sample below with the <> as part of the text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
I am still not sure we should bend the standard like that... especially as it will break things like the sample below with the <> as part of the text.
I think you are correct and we should not bend the standard like this, marking this as wont fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #8)
(In reply to Katrin Fischer from comment #7)
I am still not sure we should bend the standard like that... especially as it will break things like the sample below with the <> as part of the text.
I think you are correct and we should not bend the standard like this, marking this as wont fix.
I'm not sure I follow. Which standard would be bent by allowing HTML? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- On the topic of standards, I think that this is my favourite MARC field: 887 - Non-MARC Information Field (R) https://www.loc.gov/marc/bibliographic/bd887.html I think it was probably intended for XML data outside the MARC schema, but I've seen some wild things in there before... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #10)
On the topic of standards, I think that this is my favourite MARC field:
887 - Non-MARC Information Field (R) https://www.loc.gov/marc/bibliographic/bd887.html
I think it was probably intended for XML data outside the MARC schema, but I've seen some wild things in there before...
Technically, I would say that XHTML is allowed in the 887 at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem is not the HTML so much as the expectation that it should render... and then it will be used for formatting, which is not a good mix usually - formatting and data. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org