[Bug 27239] New: FRBRizeEditions is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Bug ID: 27239 Summary: FRBRizeEditions is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org Hi Even if FRBRizeEditions and OPACFRBRizeEditions are set Editions tab isn't displayed in staff and Opac notices detail. Test plan: 1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions 2 - Search for a notice with multiple ISBN in ThingISBN and with some of these ISBNs in Koha. Example: http://www.librarything.com/api/thingISBN/0452254264 In koha imported from LOC ISBN: 0452254264 0198185219 3 - Select one notice 4 - Edition tab is not there. 5 - Apply patch 6 - Redo 2 6 - QED, Edition tab is there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 --- Comment #1 from Didier Gautheron <didier.gautheron@biblibre.com> --- Created attachment 114407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114407&action=edit Bug 27239: Detail templates remove redundant tests Template variables FRBRizeEditions and OPACFRBRizeEditions aren't assigned with syspref values and are redundant anyway. If syspref FRBRizeEditions or OPACFRBRizeEditions aren't set XISBN is empty. Test plan: 1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions 2 - Search for a notice with multiple ISBN in ThingISBN and with some of these ISBNs in Koha. Example: http://www.librarything.com/api/thingISBN/0452254264 In koha imported from LOC ISBN: 0452254264 0198185219 3 - Select one notice 4 - Edition tab is not there. 5 - Apply patch 6 - Redo 2 7 - Edition tab is there. 8 - Unset FRBRizeEditions and OPACFRBRizeEditions 9 - Edition tab isn't there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114407|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119618&action=edit Bug 27239: Detail templates remove redundant test Template variables FRBRizeEditions and OPACFRBRizeEditions aren't assigned with syspref values and are redundant anyway. If syspref FRBRizeEditions or OPACFRBRizeEditions aren't set XISBN is empty. Test plan: 1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions 2 - Search for a notice with multiple ISBN in ThingISBN and with some of these ISBNs in Koha. Example: http://www.librarything.com/api/thingISBN/0452254264 In koha imported from LOC ISBN: 0452254264 0198185219 3 - Select one notice 4 - Edition tab is not there. 5 - Apply patch 6 - Redo 2 7 - Edition tab is there. 8 - Unset FRBRizeEditions and OPACFRBRizeEditions 9 - Edition tab isn't there. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119618|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119806&action=edit Bug 27239: Detail templates remove redundant test Template variables FRBRizeEditions and OPACFRBRizeEditions aren't assigned with syspref values and are redundant anyway. If syspref FRBRizeEditions or OPACFRBRizeEditions aren't set XISBN is empty. Test plan: 1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions 2 - Search for a notice with multiple ISBN in ThingISBN and with some of these ISBNs in Koha. Example: http://www.librarything.com/api/thingISBN/0452254264 In koha imported from LOC ISBN: 0452254264 0198185219 3 - Select one notice 4 - Edition tab is not there. 5 - Apply patch 6 - Redo 2 7 - Edition tab is there. 8 - Unset FRBRizeEditions and OPACFRBRizeEditions 9 - Edition tab isn't there. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't recreate the problem without the patch. 1. Edit biblionumber=1 2. 020 => 0452254264 => Detail pages (both staff and OPAC) have the "Editions" tab The sysprefs are passed from C4::Auth % grep FRBRizeEditions C4/Auth.pm FRBRizeEditions => C4::Context->preference("FRBRizeEditions"), OPACFRBRizeEditions => C4::Context->preference("OPACFRBRizeEditions"), Please provide more infos -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org