[Bug 9370] New: use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Bug ID: 9370 Summary: use Library::CallNumber::LC when splitting LC call numbers for spine labels Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: gmcharlt@gmail.com We should switch to using Library::CallNumber::LC for splitting LC call numbers when generating spine labels for several reasons: [1] Library::CallNumber::LC was written specifically for parsing LC call numbers, while the current code in Koha was developed based on very few examples. [2] The module is currently being used by Evergreen. Any future efforts to improve LC call number parsing by updating Library::CallNumber::LC would benefit both ILS projects. [3] In bug 6281, I'm proposing using this module to improve sorting of LC call numbers. Using the module would reduce redundancy in Koha's code base. [4] And, perhaps most importantly, it solves a problem reported by a library. The immediate motivation for this change is an example call number that one of our customers noted is being split incorrectly. The LC number 'QH541.15.C6 C25 2012' is currently being split like this: QH 541 .15 .C6 C25 2012 It should actually be split as follows: QH 541.15 .C6 C25 2012 The ".15" after "541" is part of the main class number; it isn't a Cutter. To test: [1] Add an item record with the call number QH541.15.C6 C25 2012 and set it classification source to lcc. [2] Generate a spine label and verify that the call number is split like this: QH 541.15 .C6 C25 2012 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2500 Depends on| |6281 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14481&action=edit bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14482&action=edit bug 9370: add invalid call number to LC splitting test cases '123 ABC FOO BAR' is intentionally *not* a valid LC call number, but in order to preserve legacy behavior, it should be split on whitespace. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14483&action=edit bug 9370: improve splitting of LC call numbers for labels Use the Perl module Library::CallNumber::LC to parse and split LC call numbers when generating spine labels. For example, QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 To test, create an item with call number QH541.15.C6 C25 2012 and classification source LC, then create a spine label for that item using a layout of type 'biblio' that has the split call numbers option enabled. The call number should be split as indicated above. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Note that the three patches for this bug require installing the patches for bug 6281. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14481|0 |1 is obsolete| | Attachment #14482|0 |1 is obsolete| | Attachment #14483|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15355&action=edit bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15356&action=edit bug 9370: add invalid call number to LC splitting test cases '123 ABC FOO BAR' is intentionally *not* a valid LC call number, but in order to preserve legacy behavior, it should be split on whitespace. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15357&action=edit bug 9370: improve splitting of LC call numbers for labels Use the Perl module Library::CallNumber::LC to parse and split LC call numbers when generating spine labels. For example, QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 To test, create an item with call number QH541.15.C6 C25 2012 and classification source LC, then create a spine label for that item using a layout of type 'biblio' that has the split call numbers option enabled. The call number should be split as indicated above. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Just noting that as of today, the patch series still applies cleanly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #8)
Just noting that as of today, the patch series still applies cleanly.
Galen, yes but they depend on bug 6281 which fails qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #9)
(In reply to comment #8)
Just noting that as of today, the patch series still applies cleanly.
Galen, yes but they depend on bug 6281 which fails qa.
Its now in master, so QAing this now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15355|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18865&action=edit bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=9730 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15356|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18866&action=edit bug 9370: add invalid call number to LC splitting test cases '123 ABC FOO BAR' is intentionally *not* a valid LC call number, but in order to preserve legacy behavior, it should be split on whitespace. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=9730 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15357|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18867&action=edit bug 9370: improve splitting of LC call numbers for labels Use the Perl module Library::CallNumber::LC to parse and split LC call numbers when generating spine labels. For example, QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 To test, create an item with call number QH541.15.C6 C25 2012 and classification source LC, then create a spine label for that item using a layout of type 'biblio' that has the split call numbers option enabled. The call number should be split as indicated above. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. I'm not sure why marking it enh instead of normal. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #17 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15241 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org