https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121668&action=edit Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121668|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 121697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121697&action=edit Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121697|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121857&action=edit Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.08 -- You are receiving this mail because: You are watching all bug changes.