[Bug 16562] New: Translatability: Issue in opac-user.tt (separated word 'item')
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Bug ID: 16562 Summary: Translatability: Issue in opac-user.tt (separated word 'item') Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The following sentence needs a better wording to avoid translation problems: Pending for next available <i>[% ItemTypes.GetDescription( RESERVE.itemtype ) %]</i> item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 51716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51716&action=edit Bug 16562: Translatability: Issue in opac-user.tt (separated word 'item') This patch fixes translatoion difficulties (syntax) with a tag-separated word 'item' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51716|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51849&action=edit [SIGNED-OFF] Bug 16562: Translatability: Issue in opac-user.tt (separated word 'item') This patch fixes translatoion difficulties (syntax) with a tag-separated word 'item' Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure it will make the translation easier, but I don't have something else to suggest. Letting it here to get another QA point of view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why don't you just remove the i tag and surround the whole sentence with a span? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)
Not sure it will make the translation easier, but I don't have something else to suggest. Letting it here to get another QA point of view.
I'll add a : to the text to make clear that a value will follow. It will read: Pending for next available item of type: Book (Book in italic) That is nicer because item types start with a capital letter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 52230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52230&action=edit Bug 16562: (Follow-up) Add ':' to enhance readability and translatability The text will now read: Pending for next available item of type: Book (Book in italic) This is nicer because item types normally start with a capital letter and because it will be clearer in translation that a value will follow. See comments #5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
Why don't you just remove the i tag and surround the whole sentence with a span?
And what about this suggestion? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #8 from Marc Véron <veron@veron.ch> --- It would read: Pending for next available item of type Book I like it better the way I did it, for the reason I explained in my comment. Pending for next available item of type: <i>Book</i> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #8)
It would read: Pending for next available item of type Book
I like it better the way I did it, for the reason I explained in my comment. Pending for next available item of type: <i>Book</i>
I meant: Pending for next available Book item. i.e. same wording as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #9)
(In reply to Marc Véron from comment #8)
It would read: Pending for next available item of type Book
I like it better the way I did it, for the reason I explained in my comment. Pending for next available item of type: <i>Book</i>
I meant: Pending for next available Book item.
i.e. same wording as before
In Pootle, that would be: Pending for next available %s item. Translaters would have to find out what the %s stands for, that's why IMO my solution is better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I let this one for someone else, but I am pretty sure we could find something better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, thinking of other ways to format this. One thing standing out to me is the 'type', I'd like it better to use 'item of item type' to be very clear what this type thing is about :) Suggestion: Pending for next available item of item type '[% ItemTypes.GetDescription( RESERVE.itemtype ) %]' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 52552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52552&action=edit Bug 16562 - Translatability: Issue in opac-user.tt (separated word 'item') Alternate patch with wording as proposed in comment #12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51849|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52552|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52819&action=edit Bug 16562 - Translatability: Issue in opac-user.tt (separated word 'item') Alternate patch with wording as proposed in comment #12 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org