[Bug 7706] New: AuthorisedValueImages not displaying all images on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Priority: P5 - low Change sponsored?: --- Bug ID: 7706 Assignee: adrien.saurat@biblibre.com Summary: AuthorisedValueImages not displaying all images on the OPAC QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha The system preference "AuthorisedValueImages" is supposed to display/hide "images for authorized values (such as lost statuses and locations) in search results and item detail pages on the OPAC". The ccode images should appear too. As it is now : * no images are displayed on the result page * ccode and lost are displayed on the detail page * location is never displayed To be added : * ccode, lost and location in the result page * location in the detail page Note : There's also a translation problem (in french) for the AuthorisedValueImages system preference. When you choose to activate it, it is disabled instead (and enabled when you want to disable it...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- I tested on master today and * ccode and lost are displayed on the detail page Is not true anymore - ccode images are not showing on the detail page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- This is still an issue - ccode icons are not showing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Assignee|adrien.saurat@biblibre.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- AuthorisedValueImages syspref description is missing some details. Fist of all, this syspref applies only if XSLT is off (Looks like DisplayOPACiconsXSLT syspref manages the case with XSLT). Looking at code, it appears that this syspref only manages the fields of biblio using authorized values, not the fields of item. This is logical because images are shown with other biblio informations, not with items. So ccode image is displayed only if defined at biblio level. In OPAC details page, items table can show an image for lost status. But there is a little bug. Adding an image for location would be an enhancement and I think it should use a new Template Toolkit plugin. Note that itemtype image is managed by noItemTypeImages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> ---
Fist of all, this syspref applies only if XSLT is off (Looks like DisplayOPACiconsXSLT syspref manages the case with XSLT). Correction : it does not depend on XSLT
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9740 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I found a bug on detail pages : When XSLT is on, the images are not displayed ; it works when XSLT is off. The cause of this bug is corrected by Bug 9740 : when XSLT is on, the authorized value codes are replaced by there description in all page, this affects the authorized value images. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19722&action=edit Bug 7706 - use AuthorisedValueImages in opac-detail.pl AuthorisedValueImages syspref was missing from opac-details. See commit comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19724&action=edit Bug 7706 - Do not display authorized value image if url is empty Small bug : if authorized value image url is empty (not undefined) the image was shows but without src the alt was shown. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19725&action=edit Bug 7706 - Show image in item lost status Small bug on lost image in detail page : See commit message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 9740 which is in status Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to I'm just a bot from comment #9)
This bug depends on 9740 which is in status Failed QA
Setting status to BLOCKED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |NEW --- Comment #11 from Nicole C. Engard <nengard@gmail.com> --- 9740 is no longer failed qa so updating status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- Do we need a new patch for this? Or is this supposed to be Needs Signoff? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 9740 is still "in discussion" - not sure about the patches here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- Changing to needs sign off since we have patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry, this patchset references files from OPAC prog :( CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree. CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org