[Bug 42498] New: Accessibility - Page tabs/pagination on results in opac gives "Aria state or property has invalid value"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Bug ID: 42498 Summary: Accessibility - Page tabs/pagination on results in opac gives "Aria state or property has invalid value" Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: danielle.elder@law.utexas.edu QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org I am working on the accessibility of our public catalog. One error flagged on in our Kioha catalog is "ARIA state or property has invalid value." Then it lists this html. 1. That "active" is not a valid value of aria-current and 2. that it is applied to the list and to the list elements (so twice.) <li class="page-item active" aria-current="active"> <a class="page-link" href="#" aria-label="Current page: Page 1" aria-current="true">1</a> </li> Example page: https://tallons.law.utexas.edu/cgi-bin/koha/opac-search.pl?q=an:2414 aria-current does NOT accept arbitrary values like "active". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility - Page |Accessibility - Page |tabs/pagination on results |tabs/pagination on results |in opac gives "Aria state |in opac produces error |or property has invalid |"Aria state or property has |value" |invalid value" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility - Page |Accessibility - Page |tabs/pagination on results |tabs/pagination on results |in opac produces error |in opac produces |"Aria state or property has |accessibility error "Aria |invalid value" |state or property has | |invalid value" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Comma delimited| |Athens County Public list of Sponsors| |Libraries Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198607&action=edit Bug 42498: Fix invalid aria attribute in OPAC search results pagination This patch corrects the aria-current attribute in OPAC search results pagination. There should be no aria-current attribute on the list item, and the aria-current value on the link should be "page." To test, apply the patch and perform a catalog search in the OPAC which will return multiple pages of results. View the page source or use the developer console to inspect the HTML of the active pagination link. It should have an aria-current label with the value "page." The containing list item should not have an aria-current label. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 198730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198730&action=edit Bug 42498: Fix invalid aria attribute in OPAC search results pagination This patch corrects the aria-current attribute in OPAC search results pagination. There should be no aria-current attribute on the list item, and the aria-current value on the link should be "page." To test, apply the patch and perform a catalog search in the OPAC which will return multiple pages of results. View the page source or use the developer console to inspect the HTML of the active pagination link. It should have an aria-current label with the value "page." The containing list item should not have an aria-current label. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 --- Comment #3 from Dani Elder <danielle.elder@law.utexas.edu> --- Thanks for your work on this. Would be great if it can be backported if it gets through QA and such. Accessibility it becoming very highly scrutinized for us (and likely other institutions) because of the new laws in the US and getting these updates will help with our compliance with those laws. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199711&action=edit Bug 42498: Fix invalid aria attribute in OPAC search results pagination This patch corrects the aria-current attribute in OPAC search results pagination. There should be no aria-current attribute on the list item, and the aria-current value on the link should be "page." To test, apply the patch and perform a catalog search in the OPAC which will return multiple pages of results. View the page source or use the developer console to inspect the HTML of the active pagination link. It should have an aria-current label with the value "page." The containing list item should not have an aria-current label. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42498 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.06 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.06 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org