[Bug 12428] New: "OPAC info" is not displayed in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Bug ID: 12428 Summary: "OPAC info" is not displayed in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org Bug 7264 made it possible to enter a piece of "OPAC info" for each library, and have it displayed as a tooltip on the library name in the items table on the detail view in the OPAC. This functionality now seems to be broken, I can't get anything to display when I hover over the library name. The Firebug JS console does not show any errors. Tested in Firefox 30.0 on Ubuntu 14.04. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Git bisect blames this commit (Bug 7720): http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=09ce37d349340f9a... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 28877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28877&action=edit Bug 12428 - "OPAC info" is not displayed in the OPAC The changes made by Bug 7720 ("Ambiguity in OPAC Details location") broke the display of OPAC branch information tooltips by making changes to the markup which the tooltip plugin needs to function. This patch corrects the markup to enable tooltips to work again. This patch also makes changes to Items.pm so that branch information tooltips can be shown for both home and holding branches (which are optionally displayed now via the changes by Bug 7720). Before this patch the tooltip would always display the information for the holding branch regardless of the OpacLocationBranchToDisplay setting. This patch also changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record under various values of the OpacLocationBranchToDisplay system preference: - "holding library" : The table of holdings should show a column for only the holding library. Hovering your cursor over the library name should display the branch information you configured for that library in a tooltip . - "home and holding library" : The table of holdings should show columns for both home and holding library. Hovering your cursor over each should show the corresponding library information tooltips. - "home library" : The table of holdings should show a column for only the home library. Hovering your cursor over the library name should display the branch information you configured for that library in a tooltip. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29060&action=edit Bug 12428 - "OPAC info" is not displayed in the OPAC The changes made by Bug 7720 ("Ambiguity in OPAC Details location") broke the display of OPAC branch information tooltips by making changes to the markup which the tooltip plugin needs to function. This patch corrects the markup to enable tooltips to work again. This patch also makes changes to Items.pm so that branch information tooltips can be shown for both home and holding branches (which are optionally displayed now via the changes by Bug 7720). Before this patch the tooltip would always display the information for the holding branch regardless of the OpacLocationBranchToDisplay setting. This patch also changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record under various values of the OpacLocationBranchToDisplay system preference: - "holding library" : The table of holdings should show a column for only the holding library. Hovering your cursor over the library name should display the branch information you configured for that library in a tooltip . - "home and holding library" : The table of holdings should show columns for both home and holding library. Hovering your cursor over each should show the corresponding library information tooltips. - "home library" : The table of holdings should show a column for only the home library. Hovering your cursor over the library name should display the branch information you configured for that library in a tooltip. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Everything works as outlined in the test plan. Thank you, Owen, for a great patch. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29060|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29062&action=edit [PASSED QA] Bug 12428 - "OPAC info" is not displayed in the OPAC The changes made by Bug 7720 ("Ambiguity in OPAC Details location") broke the display of OPAC branch information tooltips by making changes to the markup which the tooltip plugin needs to function. This patch corrects the markup to enable tooltips to work again. This patch also makes changes to Items.pm so that branch information tooltips can be shown for both home and holding branches (which are optionally displayed now via the changes by Bug 7720). Before this patch the tooltip would always display the information for the holding branch regardless of the OpacLocationBranchToDisplay setting. This patch also changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record under various values of the OpacLocationBranchToDisplay system preference: - "holding library" : The table of holdings should show a column for only the holding library. Hovering your cursor over the library name should display the branch information you configured for that library in a tooltip . - "home and holding library" : The table of holdings should show columns for both home and holding library. Hovering your cursor over each should show the corresponding library information tooltips. - "home library" : The table of holdings should show a column for only the home library. Hovering your cursor over the library name should display the branch information you configured for that library in a tooltip. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Works with all settings of OpacLocationBranchToDisplay. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29179&action=edit Bug 12428: (QA followup) regression tests. Just that. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal@bywatersolutions.co | |m --- Comment #9 from Ed Veal <ed.veal@bywatersolutions.com> --- Will this patch get back ported? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Ed Veal from comment #9)
Will this patch get back ported?
Please ping Galen on this matter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29062|0 |1 is obsolete| | Attachment #29179|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34094&action=edit Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon@cdalibrary.org, |gmcharlt@gmail.com |ed.veal@bywatersolutions.co | |m, sandboxes@biblibre.com, | |tomascohen@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt@gmail.com |mtj@kohaaloha.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com --- Comment #12 from Koha Team AMU <koha.aixmarseille@gmail.com> --- I applied and tested this patch on a sandbox. It works like expected. But I was not able to change status in "signed off". When I tried, I had the following message "It seems you don't have applied a patch, so you cannot sign it off. If you applied patches from the right report, check the commit message of the last patch. It should start with "Bug XXXXX", if not, please inform the author of the patch." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch is targetted at 3.16 specifically, so I think it might not be testable on a sandbox successfully. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34094|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34692&action=edit [SIGNED OFF]Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34692|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34722&action=edit [PASSED QA] Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #16 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #17 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch is in 3.16.x, I set to Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #18 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org