[Bug 30003] New: When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Bug ID: 30003 Summary: When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org (Possibly related to #28163 at a code level) Hi, One of our customers has raised a curious bug involving the Point of Sale module within Koha. Specifically, when processing a payment in Koha, if the 'amount tendered' field is left blank, then filled in after the 'this field is mandatory' text appears, the transaction seems to be recorded twice. Please see here for a visual demo: https://i.imgur.com/upH5zlk.gifv Steps to reproduce: 1. Navigate to /cgi-bin/koha/pos/pay.pl 2. Add an item from 'items to purchase' 3. Under 'collect payment', click submit without altering the form 4. See 'This field is required.' 5. Now, fill a value in 'Amount tendered' that satisfies or exceeds 'Amount being paid' 6. The payment should succeed 7. Navigate to /cgi-bin/koha/pos/register.pl 8. See duplicate lines in Transactions I hope we can see this resolved quickly, as it has the potential to cause major accounting issues. Many thanks, Jake Deery -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #1 from Jake Deery <jake.deery@ptfs-europe.com> --- Just to update, I have applied a quick-fix to IntranetUserJS. See attached. I will look into creating a proper patch tonight - -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #2 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 130280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130280&action=edit Applied a fix to stop point-of-sale items being added twice to till transaction lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28163 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130280|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 130423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130423&action=edit Applied a fix to stop point-of-sale items being added twice to till transaction lists https://bugs.koha-community.org/show_bug.cgi?id=30003 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works great, thanks Jake! We have this problem with a couple of staff at one library, and we couldn't get to the bottom of it; invariably, whenever we were watching them process a transaction, they did it perfectly. Now we know the cause! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Jake is just fixing up the commit message to adhere to guidelines.. you guys we so quick :). I'll help him re-apply the signoff line ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #6 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 130425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130425&action=edit Bug 30003: Fix to stop point-of-sale items being added twice to transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130425|0 |1 is obsolete| | --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 130427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130427&action=edit Bug 30003: Fix to stop point-of-sale items being added twice to transactions https://bugs.koha-community.org/show_bug.cgi?id=30003 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #8 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 130428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130428&action=edit Bug 30003: Prevent double up of point-of-sale items This patch prevents the double submission of point-of-sale items when form validation fails at the first submission Test plan 1. Navigate to /cgi-bin/koha/pos/pay.pl 2. Add an item from 'items to purchase' 3. Under 'collect payment', click submit without altering the form 4. See 'This field is required.' 5. Now, fill a value in 'Amount tendered' that satisfies or exceeds 'Amount being paid' 6. The payment should succeed 7. Navigate to /cgi-bin/koha/pos/register.pl 8. See duplicate lines in Transactions Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130427|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #9 from Jake Deery <jake.deery@ptfs-europe.com> --- Right - apologies for the repeated attachments. Still getting the hang of git-bz ;-) Big thanks to Martin and Sally for taking a look at this, and Kyle for adding the sign-off line! Let me know how I can assist in the next steps. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@ptfs-europe.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 28163 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When leaving 'Amount |Register entries doubled up |Tendered' blank, then |if form fails validation on |filling in a value, two |first submission |transactions are recorded | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jake, thx for your patch and don't worry about the bugzilla noise, we all do it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't know if I am testing this correctly but with the patch I am not seeing anything on pos/register.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130428|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132249&action=edit Bug 30003: Prevent double up of point-of-sale items This patch prevents the double submission of point-of-sale items when form validation fails at the first submission Test plan 1. Navigate to /cgi-bin/koha/pos/pay.pl 2. Add an item from 'items to purchase' 3. Under 'collect payment', click submit without altering the form 4. See 'This field is required.' 5. Now, fill a value in 'Amount tendered' that satisfies or exceeds 'Amount being paid' 6. The payment should succeed 7. Navigate to /cgi-bin/koha/pos/register.pl 8. See duplicate lines in Transactions 9. Apply patch 10. Repeat 2-6 11. Navigate to /cgi-bin/koha/pos/register.pl 12. Confirm only a single line was added Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- This feels slightly hacky - it seems the "This sale" table should be part of the payment form so we don't have to copy/delete lines on every attempt This seems like a nasty bug however, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org