[Bug 20502] New: Record URL broken, when there is more than one 856 on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Bug ID: 20502 Summary: Record URL broken, when there is more than one 856 on the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: kyle@bywatersolutions.com When there is more than one 856 in the record, the Record URL in the course reserves table creates a broken link. Example form the sample data: http://www.loc.gov/catdir/enhancements/fy1010/2009039494-b.html%20|%20http://www.loc.gov/catdir/enhancements/fy1010/2009039494-d.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We should not use biblioitems.url but GetMarcUrls instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid in 18.11 at least, possibly master as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #3 from Donna <bwsdonna@gmail.com> --- This is still an issue in 19.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108712&action=edit Bug 20502: Split URI on course detail view If there are more that one URIs for biblio or item, we should split the value. This patch reuses the same code as bug 24697. Test plan: Add one item to a course Add several URI for this item and for its biblio Show the course detail view The different URI of the item must be displayed Remove all URI for the item Show the course detail view The different URI of the biblio must be displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24697 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108712|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 108737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108737&action=edit Bug 20502: Split URI on course detail view If there are more that one URIs for biblio or item, we should split the value. This patch reuses the same code as bug 24697. Test plan: Add one item to a course Add several URI for this item and for its biblio Show the course detail view The different URI of the item must be displayed Remove all URI for the item Show the course detail view The different URI of the biblio must be displayed Signed-off-by: Donna Bachowski <donna@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works for staff, can we have the same change for OPAC please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108775&action=edit Bug 20502: Split URI on course detail view - OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |oleonard@myacpl.org --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about the behaviour change here where we display the URL when there is more than one. At the moment these display not very nicely in the table :( I think the best would be to display "Item URL" for item URLs as it's now and display the link text for 856 or keept the current "Record URL" (first is a wish... second probably doable). What do you think? There is also a bug when there is only one URL for a course item: I think cr.biblioitem.url.split should be cr.biblioitem.uri.split -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116636&action=edit Bug 20502: Fix url vs uri -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116637&action=edit Bug 20502: Replace texts with 'Link to resource' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8)
I am not sure about the behaviour change here where we display the URL when there is more than one. At the moment these display not very nicely in the table :(
I think the best would be to display "Item URL" for item URLs as it's now and display the link text for 856 or keept the current "Record URL" (first is a wish... second probably doable).
What do you think?
I don't understand, can you rephrase? My patch is applying what is done on catalogue/detail.pl, so not sure how it is displaying "not very nicely". There is an optional follow-up patch that replaces the text with "Link to resource"
There is also a bug when there is only one URL for a course item: I think cr.biblioitem.url.split should be cr.biblioitem.uri.split
Fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The last patch uses the same text in a foreach. Looks very ugly? I would stick to your original plan to mimic catalogue/detail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108737|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 116788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116788&action=edit Bug 20502: Split URI on course detail view If there are more that one URIs for biblio or item, we should split the value. This patch reuses the same code as bug 24697. Test plan: Add one item to a course Add several URI for this item and for its biblio Show the course detail view The different URI of the item must be displayed Remove all URI for the item Show the course detail view The different URI of the biblio must be displayed Signed-off-by: Donna Bachowski <donna@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108775|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 116789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116789&action=edit Bug 20502: Split URI on course detail view - OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116636|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 116790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116790&action=edit Bug 20502: Fix url vs uri Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116637|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 116791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116791&action=edit Bug 20502: Replace texts with 'Link to resource' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116791|Bug 20502: Replace texts |[NOT_SIGNED] Bug 20502: description|with 'Link to resource' |Replace texts with 'Link to | |resource' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I did not signoff on the last one ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Moved to In discussion for the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is stuck, how do we move forward? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18599 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org