https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |liz@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 64714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64714&action=edit Bug 18527 - Add a system preference to exclude renewals from the quick slip To test: Set up your test case: Issue 4 books to a borrower. 1 we leave alone, that's today's issue. 2 Renew one of them - that's today's renewal. 3 Back date the issue date on the third one, in the database. Do not renew it. This is an issue not from today that has not been renewed. 4 Back date the issue date on the fourth, and set a renew date in the past in the database. This is an issue not from today that has been renewed in the past. With the syspref ShowRenewalsQuickSlip set to "Show" Print a quick slip for this borrower, you should see only issues 1 and 2. 3 and 4 should never appear on this slip. This is the current behaviour of the quick slip, nothing should change. This is also the default of the syspref. With the syspref ShowRenewalsQuickSlip set to "Don't show" Print a quick slip for this borrower, you should see only issue 1 (today's issue) Issues 2, 3, and 4 should not appear on this slip. This is the new behaviour, and must be activated by changing the syspref. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12355 CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64714|0 |1 is obsolete| | --- Comment #4 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64988&action=edit Bug 18527 - Add a system preference to exclude renewals from the quick slip To test: Set up your test case: Issue 4 books to a borrower. 1 we leave alone, that's today's issue. 2 Renew one of them - that's today's renewal. 3 Back date the issue date on the third one, in the database. Do not renew it. This is an issue not from today that has not been renewed. 4 Back date the issue date on the fourth, and set a renew date in the past in the database. This is an issue not from today that has been renewed in the past. With the syspref ShowRenewalsQuickSlip set to "Show" Print a quick slip for this borrower, you should see only issues 1 and 2. 3 and 4 should never appear on this slip. This is the current behaviour of the quick slip, nothing should change. This is also the default of the syspref. With the syspref ShowRenewalsQuickSlip set to "Don't show" Print a quick slip for this borrower, you should see only issue 1 (today's issue) Issues 2, 3, and 4 should not appear on this slip. This is the new behaviour, and must be activated by changing the syspref. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hi, I re committed your patch atomic update, I don't know why it was inversed (the patch wanted to delete from the code what you actually wrote). However all work well, but I think the QA won't accept the default setting of the syspref to 1. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17966 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is typically the kind of thing that will be easy to do using the TT syntax (see bug 17966). I am not in favour of adding a new pref for that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we document how this would work with TT? Excluding the renewed ones = removing checkouts with last renewal today? -- You are receiving this mail because: You are watching all bug changes.