[Bug 9309] New: "OPACurlOpenInNewWindow" isn't respected for 852$u links shown in OPAC when not using XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Bug ID: 9309 Summary: "OPACurlOpenInNewWindow" isn't respected for 852$u links shown in OPAC when not using XSLT Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: robin@catalyst.net.nz On the surface, this looks like a problem from the conversion to T::T. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"OPACurlOpenInNewWindow" |"OPACurlOpenInNewWindow" |isn't respected for 852$u |isn't respected for 856$u |links shown in OPAC when |links shown in OPAC when |not using XSLT |not using XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 14206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14206&action=edit Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Note that this backports to 3.8 quite happily. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14206|0 |1 is obsolete| | --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 14207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14207&action=edit Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This doesn't work for me unless I replace "OPACurlOpenInNewWindow" with "OPACURLOpenInNewWindow" (matching the case of the system preference). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- In that case, there'll be a multitude of bugs: $ grep OPACurlOpenInNewWindow koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | wc -l 6 Also, I just retested it, and it works for me as it's submitted here. However it does make more sense for the capitalisation to match, so I'll fix that up for this case. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 14330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14330&action=edit Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14330|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14333&action=edit [SIGNED-OFF] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: The patch fixes a variable scoping and reintroduces a broken feature. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14567&action=edit Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.9 and 3.10.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org