https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 148195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148195&action=edit Bug 33231 (Bug 30813 follow-up) No publication date in Z39.50 biblio search results After executing Z39.50 search, the result table is not populated with publication dates. This is the result of code refactoring made by Bug 30813. The removed function _add_rowdata treated in special way the publication date putting it in $row in under special, non MARC variant dependent key 'date'--since the z3950_search.tt looks under breeding_loo.date. Test plan: ========= 1. Have a Koha instance with some Z39.50 servers defined. 2. In Cataloging, perform a Z39.50 search for any term. 3. In the result table you would not get the publication dates. 4. Apply the patch. 5. Repeat the search. 6. You should see the publication dates (according to the current mapping, i.e. for MARC 21 coming from 260 $c or 264 $c subfield). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148195|0 |1 is obsolete| | --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 148196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148196&action=edit Bug 33231 (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results After executing Z39.50 search, the result table is not populated with publication dates. This is the result of code refactoring made by Bug 30813. The removed function _add_rowdata treated in special way the publication date putting it in $row in under special, non MARC variant dependent key 'date'--since the z3950_search.tt looks under breeding_loo.date. Same effect (no data in the result table) with edition statement. Reason: editionstatement coming from TransformMarcToKoha vs edition expected by z3950_search.tt. Test plan: ========== 1. Have a Koha instance with some Z39.50 servers defined. 2. In Cataloging, perform a Z39.50 search for any term. 3. In the result table you would not get the publication dates nor edition statement (if present in the record). 4. Apply the patch. 5. Repeat the search. 6. You should see the publication dates (according to the current mapping, i.e. for MARC 21 coming from 260 $c or 264 $c subfield) and edition statements from the records found. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148196|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 149142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149142&action=edit Bug 33231 (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results After executing Z39.50 search, the result table is not populated with publication dates. This is the result of code refactoring made by Bug 30813. The removed function _add_rowdata treated in special way the publication date putting it in $row in under special, non MARC variant dependent key 'date'--since the z3950_search.tt looks under breeding_loo.date. Same effect (no data in the result table) with edition statement. Reason: editionstatement coming from TransformMarcToKoha vs edition expected by z3950_search.tt. Test plan: ========== 1. Have a Koha instance with some Z39.50 servers defined. 2. In Cataloging, perform a Z39.50 search for any term. 3. In the result table you would not get the publication dates nor edition statement (if present in the record). 4. Apply the patch. 5. Repeat the search. 6. You should see the publication dates (according to the current mapping, i.e. for MARC 21 coming from 260 $c or 264 $c subfield) and edition statements from the records found. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149613&action=edit Bug 33231: (QA follow-up) Simplify conditional for date display This patch simply checks if we have a value for copyrighydate and displays publicationyear if not. Even if copyrightdate is requested (MARC21) but isn't populated, the publicatoinyear won't replace it because we haven't transformed that field. I think this read a bit easier, but RM can weigh in Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #149142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.