[Bug 31520] New: Only log ILL changes that are actual changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520 Bug ID: 31520 Summary: Only log ILL changes that are actual changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no "Bug 20750 - Allow timestamped auditing of ILL request events" added the ability to log status changes to ILL requests, in the action_logs table, with action = 'STATUS_CHANGE'. I have an ILL setup where a remote API is checked for data every 3 minutes, and requests are updated. With Illlog = on, this leads to 480 action_logs entries per 24-hour period. I have a test setup where the amount of logs was causing the detailed display of illrequests to time out, because there were so many log entries to fetch. This could be improved if we only logged actual status changes. Today there is a log entry even if the status is not changed: | ILL | STATUS_CHANGE | {"status_after":"IN_LEV","log_origin":"core","status_before":"IN_LEV"} | | ILL | STATUS_CHANGE | {"status_after":"IN_LEV","status_before":"IN_LEV","log_origin":"core"} | | ILL | STATUS_CHANGE | {"status_before":"IN_LEV","status_after":"IN_LEV","log_origin":"core"} | | ILL | STATUS_CHANGE | {"log_origin":"core","status_before":"IN_LEV","status_after":"IN_LEV"} | | ILL | STATUS_CHANGE | {"status_before":"IN_LEV","status_after":"IN_LEV","log_origin":"core"} | | ILL | STATUS_CHANGE | {"status_after":"IN_LEV","log_origin":"core","status_before":"IN_LEV"} | +--------+---------------+------------------------------------------------------------------------+ We could compare status_before and status_after, and only log if they differ. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- Still a problem! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520 --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 196613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196613&action=edit Bug 31520: Only log actual ILL status changes Patch from commit 4b8d6b6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se --- Comment #3 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- We are seeing millions of useless log messages that are starting to cause problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31520 --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Andreas Jonsson from comment #2)
Created attachment 196613 [details] [review] Bug 31520: Only log actual ILL status changes
Patch from commit 4b8d6b6
Is this ready for testing? If so please add a test plan, change to "Needs signoff" and mark yourself as the assignee. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org