[Bug 29332] New: AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Bug ID: 29332 Summary: AdditionalContents displays blocks for all libraries prior to login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org If you set a content block to display only for one library, you do not want it to show prior to that library being defined. Currently, prior to OPAC login, all blocks will display as the library is not yet set.. only the 'all' block should display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126960&action=edit Bug 29332: Set default library limits in search_for_display Koha::AdditionalContents->search_for_display needs to filter to just items with a 'null' branchcode if no library_id is passed. Test plan 1/ Add some additional content blocks that should display only for specific branches. 2/ Navigate to the OPAC and note that blocks display for all libraries prior to login 3/ Login to the OPAC and note that now you only see you users library block 4/ Apply the patch 5/ Repeat steps 2 and 3 and note that now you see only the 'All libraries' blocks display prior to login and that 'All libraries' + 'Your users library' blocks appear after login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126962&action=edit Bug 29332: Unit tests This patch adds unit tests to ensure we do not leak branch specific addtional contents blocks outside of logged in sessions (i.e. where a users branch is not yet set). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126960|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126963&action=edit Bug 29332: Set default library limits in search_for_display Koha::AdditionalContents->search_for_display needs to filter to just items with a 'null' branchcode if no library_id is passed. Test plan 1/ Add some additional content blocks that should display only for specific branches. 2/ Navigate to the OPAC and note that blocks display for all libraries prior to login 3/ Login to the OPAC and note that now you only see you users library block 4/ Apply the patch 5/ Repeat steps 2 and 3 and note that now you see only the 'All libraries' blocks display prior to login and that 'All libraries' + 'Your users library' blocks appear after login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 [Bug 28955] Add option to set default branch from Apache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |lucas@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AdditionalContents displays |AdditionalContents displays |blocks for all libraries |blocks for every library |prior to login |prior to login -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126962|0 |1 is obsolete| | Attachment #126963|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126991&action=edit Bug 29332: Set default library limits in search_for_display Koha::AdditionalContents->search_for_display needs to filter to just items with a 'null' branchcode if no library_id is passed. Test plan 1/ Add some additional content blocks that should display only for specific branches. 2/ Navigate to the OPAC and note that blocks display for all libraries prior to login 3/ Login to the OPAC and note that now you only see you users library block 4/ Apply the patch 5/ Repeat steps 2 and 3 and note that now you see only the 'All libraries' blocks display prior to login and that 'All libraries' + 'Your users library' blocks appear after login. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126991|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126992&action=edit Bug 29332: Unit tests This patch adds unit tests to ensure we do not leak branch specific addtional contents blocks outside of logged in sessions (i.e. where a users branch is not yet set). Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126993&action=edit Bug 29332: Set default library limits in search_for_display Koha::AdditionalContents->search_for_display needs to filter to just items with a 'null' branchcode if no library_id is passed. Test plan 1/ Add some additional content blocks that should display only for specific branches. 2/ Navigate to the OPAC and note that blocks display for all libraries prior to login 3/ Login to the OPAC and note that now you only see you users library block 4/ Apply the patch 5/ Repeat steps 2 and 3 and note that now you see only the 'All libraries' blocks display prior to login and that 'All libraries' + 'Your users library' blocks appear after login. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Straight forward fix with test, PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org