[Bug 31842] New: Fix rebase issue for branches.tt from 29144
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Bug ID: 31842 Summary: Fix rebase issue for branches.tt from 29144 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org See comment73 on bug 29144. Looks like a rebase issue. Addressing it here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- It is no rebase issue after all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix rebase issue for |Fix issue with |branches.tt from 29144 |col.data.split for | |branches.tt from 29144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix issue with |Fix issue with |col.data.split for |col.data.split for |branches.tt from 29144 |branches.tt related to | |29144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix issue with |admin/branches: DT search |col.data.split for |generates js error on |branches.tt related to |col.data.split |29144 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141953&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + "data": "actions", There is some magic in datatables.js that is using this (for sorting, searching, etc.) and expect it to be an attribute of library. I would not use "actions". Actually it's the same of the other occurrences. It's not a problem to have a function defined for 'data', it just should not be searchable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #3)
It's not a problem to have a function defined for 'data', it just should not be searchable.
Do you agree with that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141953|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 141993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141993&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141993|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142032&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)
(In reply to Jonathan Druart from comment #3)
It's not a problem to have a function defined for 'data', it just should not be searchable.
Do you agree with that?
Hmm. It looks a bit inconsistent. I prefer the move to render now. And it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
+ "data": "actions",
There is some magic in datatables.js that is using this (for sorting, searching, etc.) and expect it to be an attribute of library. I would not use "actions".
Where can I find that? We can change these "labels" where needed.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I do see an action function but I dont see actions in datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 [Bug 31754] Improve appearance of behavior of DataTables controls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #7)
(In reply to Jonathan Druart from comment #4)
(In reply to Jonathan Druart from comment #3)
It's not a problem to have a function defined for 'data', it just should not be searchable.
Do you agree with that?
Hmm. It looks a bit inconsistent. I prefer the move to render now. And it works.
Ok but if you keep data:function and set searchable to false, it also works. "It works" is not enough ;) (In reply to Marcel de Rooy from comment #8)
(In reply to Jonathan Druart from comment #3)
+ "data": "actions",
There is some magic in datatables.js that is using this (for sorting, searching, etc.) and expect it to be an attribute of library. I would not use "actions".
Where can I find that? We can change these "labels" where needed..
"data" is not a label https://datatables.net/reference/option/columns.data vs https://datatables.net/reference/option/columns.render `data: "actions"` does not mean anything. The magic is: the DT REST API wrapper is using the "data" value to build the table, it must be a value returned by the REST API response. (In reply to Marcel de Rooy from comment #9)
I do see an action function but I dont see actions in datatables.js
See above. Occurrences are: 583 var attributes = col.data.split(':'); 607 return col.bSearchable && typeof col.data == 'string' && data.columns[col.idx].search.value != '' 685 var order_by = options.columns[order_col].data; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
Ok but if you keep data:function and set searchable to false, it also works. "It works" is not enough ;) I will revert most changes now. But imo dataTables or the additional customizations are buggy and/or inconsistent. If data may be a function, you simply need to check col.data.split.. Definitely a bug.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142032|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 142144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142144&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> {EDIT] Reverted the data/render function change as requested by Jonathan. Considering the fact that dataTables or custom extensions do not check data.col.split as a clear bug btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142144|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 142146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142146&action=edit Bug 31842: Fix DT search error on col.data.split Set searchable to false for opac_info. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Reverted the data/render function change as requested by Jonathan. Considering the fact that dataTables or custom extensions do not check data.col.split as a clear bug btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142146|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 142148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142148&action=edit Bug 31842: Fix DT search error on col.data.split Set searchable to false for opac_info. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Reverted the data/render function change as requested by Jonathan. Considering the fact that dataTables or custom extensions do not check col.data.split as a clear bug btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Edited the commit message ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #11)
(In reply to Jonathan Druart from comment #10)
Ok but if you keep data:function and set searchable to false, it also works. "It works" is not enough ;) I will revert most changes now. But imo dataTables or the additional customizations are buggy and/or inconsistent. If data may be a function, you simply need to check col.data.split.. Definitely a bug.
Are you going to file a bug about that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, after pushing this I noticed the conversation between Jonathan and Marcel is not entirely closed. My feeling now is that we have hidden the problem by making the field not searchable, but a proper solution would be a bit more complex. It this is the case, please file a bug to discuss it an I'm willing to add my two cents for the solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The bug has been addressed now. I will not file another bug, but I gave my observations here. We have more code issues. Cant solve them all ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Bug 31842 depends on bug 29144, which changed state. Bug 29144 Summary: Move branches.opac_info to AdditionalContents allowing multi language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org