https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I had a go at testing, but didn't quite get there. How do you update the po files when Vue stuff is involved? I'm sure I'm not quite getting it all yet! I tried (after installing the patch): 1. yarn build (for rebuilding Vue stuff) 2. gulp po:update --lang es-ES (as an example) 3. language was already installed (es-ES as an example) The es-ES-messages-js.po (as an example) doesn't seem to have been updated - I think this is the one that should have been udpated? Test plan so far: 1. Install another language 2. Enable the language for the staff interface (Administration > System preferences > I18N/L10N > language) 3. Enable the ERM module (ERMModule) 4. Change the language to the one you installed 5. Go to E-resource management > eHoldings > Local > Packages > +New package 6. Note that the submit button is not translated (Compare to one of the other submit buttons that is translated (E-resource management > Agreements > +New agreement) 7. Search misc/translation/po/<lang>-messages-js.po for 'Submit' - Note that there is only one line entry for 'Submit' #: koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue:11 8. Apply the patch 9. Update the Vie stuff: yarn build 10. gulp po:update --lang <lang> 11. Update the language: koha-translate --update es-ES --dev kohadev (necessary?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #3)

Hi David, I cannot test right now, but you need: 8. Apply the patch 9. yarn build (or simply yarn js:build) 10. restart_all (JS translations are cached in memcached)

That should be enough.

Thanks Jonathan! That worked. Simplified test plan: 1. Install another language, for example: koha-translate --install es-ES --dev kohadev 2. Enable the language for the staff interface (Administration > System preferences > I18N/L10N > language) 3. Enable the ERM module (ERMModule) 4. Change the language to the one you installed 5. Go to E-resource management > eHoldings > Local > Packages > +New package 6. Note that the submit button is not translated (for +New package it is Submit instead of Enviar for es-ES) (Compare to one of the other submit buttons that is translated correctly (E-resource management > Agreements > +New agreement) 7. Apply the patch, yarn js:build, restart_all 8. Repeat step 5 - the submit button is now translated! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159920&action=edit Bug 35476: Make 'Submit' translatable in TrainsFormAddItem.vue Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.