[Bug 35514] New: Total prices not updated when importing records from staged file with multiple items added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Bug ID: 35514 Summary: Total prices not updated when importing records from staged file with multiple items added Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org Hello everyone, When you add an order line to a basket from a staged file, on the neworderempty.pl page during entry the prices are correctly calculated when you add item one by one, but if you add multiple items simultaneously the total costs are not updated and adding the line leads to having the prices set to 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 159656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159656&action=edit Bug 35514: Fix costs update when adding multiple items from staged file Test plan: 1) Stage a file with records 2) Create a basket and add order line from imported records to go on neworderempty.pl 3) Choose to add one item and repeat the operation 4) See on form that the total cost is updated without update vendor price 5) Now add multiple items, for example, "2" you will see that the total cost is not updated and if you save "0" price will be set 6) Apply this patch and repeat step 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159656|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 160564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160564&action=edit Bug 35514: Fix costs update when adding multiple items from staged file Test plan: 1) Stage a file with records 2) Create a basket and add order line from imported records to go on neworderempty.pl 3) Choose to add one item and repeat the operation 4) See on form that the total cost is updated without update vendor price 5) Now add multiple items, for example, "2" you will see that the total cost is not updated and if you save "0" price will be set 6) Apply this patch and repeat step 5 Signed-off-by: Michał Dudzik <dudzikmichal@wp.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Michal Dudzik <dudzikmichal@wp.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dudzikmichal@wp.pl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160564|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161081&action=edit Bug 35514: Fix costs update when adding multiple items from staged file Test plan: 1) Stage a file with records 2) Create a basket and add order line from imported records to go on neworderempty.pl 3) Choose to add one item and repeat the operation 4) See on form that the total cost is updated without update vendor price 5) Now add multiple items, for example, "2" you will see that the total cost is not updated and if you save "0" price will be set 6) Apply this patch and repeat step 5 Signed-off-by: Michał Dudzik <dudzikmichal@wp.pl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net Summary|Total prices not updated |New order line form: Total |when importing records from |prices not updated when |staged file with multiple |adding multiple items |items added | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) testing note: Turns out it's not related to imports. It's just multiple item additions. For example adding an order from an existing record or a new empty record was also affected and fixed. Feel free to better phrase the title. The "New order line form:" part is my attempt to make it more clear which page in the order process it is. I got a bit lost in the workflow that includes before finding the right page. (maybe it's more obvious now that there isn't a the import part) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161081|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161082&action=edit Bug 35514: Fix costs update when adding multiple items from staged file Test plan: 1) Stage a file with records 2) Create a basket and add order line from imported records to go on neworderempty.pl 3) Choose to add one item and repeat the operation 4) See on form that the total cost is updated without update vendor price 5) Now add multiple items, for example, "2" you will see that the total cost is not updated 6) Apply this patch, refresh form and repeat steps 3 to 5 Signed-off-by: Michał Dudzik <dudzikmichal@wp.pl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161083&action=edit Bug 35514: Fix total cost update when adding multiple items to order Test plan: 1) Create a basket and add an order line to go on neworderempty.pl (the new order form) 2) Choose to add one item and repeat the operation 3) See on form that the total cost is updated without update vendor price 4) Now add multiple items, for example, "2" you will see that the total cost is not updated 5) Apply this patch, refresh form and repeat steps 3 to 5 Signed-off-by: Michał Dudzik <dudzikmichal@wp.pl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Victor Grousset/tuxayo from comment #4)
testing note: Turns out it's not related to imports. It's just multiple item additions. For example adding an order from an existing record or a new empty record was also affected and fixed.
Also, as far as I tested, it doesn't impact the final saved order. I couldn't get a difference between orders when hitting the bug or not (with new empty record, exiting record, staged file). The total doesn't seem to come from the form so it's correct. That divergence is weird though. @Thibaud if you indeed can reproduce an issue with the saved order, feel free to add a mention it in "Text to go in the release notes" in the ticket. (and if you can, fill it because it's empty now) @Michał did you got that part of step 5 of the original test plan? «and if you save "0" price will be set» Anyway, updated commit title and test plan to simplify and keep only the stuff that is certain. Patch can still move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #8 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Thanks @Victor for feedback.. You're right in test plan it's not necessary to have a file staged and import from this one. On the other hand, I do have the corrected behavior after applying my patch. Have you cleared the cache by any chance? I don't understand this difference in behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
On the other hand, I do have the corrected behavior after applying my patch
yes, I never seen an issue with your patch. It's the part of step 5 of the original test plan «and if you save "0" price will be set» I never see that initial issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- ah right... that's my mistake... I meant to say that the price is simply not updated... I misspoke. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Patch complexity|--- |Trivial patch Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Thibaud Guillot from comment #10)
ah right... that's my mistake... I meant to say that the price is simply not updated... I misspoke.
Great news, so no weird stuff happens to only some setups :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org