[Bug 33195] New: Reindent the bibliographic details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Bug ID: 33195 Summary: Reindent the bibliographic details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org I would like to reformat the bibliographic details page (catalogue/detail.tt) in the staff interface so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151432&action=edit Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151433&action=edit Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 [Bug 33526] Use template wrapper for tabs: Bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151486&action=edit Three related bibliographic records This MARC file can be imported and used for testing FRBRizeEditions with ThingISBN -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Bug 8377 has a sample MARC file for testing HTML5MediaEnabled: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please don't do this, I am currently working heavily on this template, see bug 33568. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
Please don't do this
Okay cool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 Status|Patch doesn't apply |BLOCKED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 [Bug 37002] Correct several HTML markup errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167346&action=edit Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167347&action=edit Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167346|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167358&action=edit Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167347|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167359&action=edit Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167358|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168724&action=edit Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167359|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168725&action=edit Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice cleanup.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is there a reason this was marked as bug? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #14)
Is there a reason this was marked as bug? :)
Nope! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This updates the template release notes| |file used to display the | |bibliographic detail page | |in the staff interface. It | |re-indents the file so that | |it has consistent | |indentation, and adds | |comments to highlight the | |markup structure. This is a | |developer-oriented change | |with no visible effect to | |the user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Bug 33195 depends on bug 37002, which changed state. Bug 37002 Summary: Correct several HTML markup errors https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37002 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Bug 33195 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org