https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20571 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79408&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Failed QA --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Hi Nick, nice enhancement, just few quick comments: 1) you should also provide sql installer data - for new installs, 2) there is missing file tools/adveditorshortcuts.pl 3) I am not sure if it should be part of tools module... 4) in file adveditorshortcuts.tt you are referencing the adveditorshortcuts.pl as reviews/adveditorshortcuts.pl - in breadcrumbs 5) could you please use bootstrap for layout of edit shortcuts page? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79408|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85365&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17179 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85365|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85397&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85397|0 |1 is obsolete| | Attachment #85398|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86012&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86014&action=edit Bug 21411: (follow-up) Missing filters and unused variable POD warnings from QA tool are false positives (basic functionsn POD not needed) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86012|0 |1 is obsolete| | Attachment #86013|0 |1 is obsolete| | Attachment #86014|0 |1 is obsolete| | --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86018&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #13 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86020&action=edit Bug 21411: (follow-up) Missing filters and unused variable POD warnings from QA tool are false positives (basic functionsn POD not needed) Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, having a first look here: 1) FAIL Koha/KeyboardShortcuts.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' 2) No tests? 3) Translation issues a) Ctrl is not labelled Ctrl on German keyboards, it's Strg - so people might not understand. Currently I can fix this in translation, but with the new system that will not work. We could add another column for a 'spelled out' mapping or we could add some replacing in the template that can be translated. Not sure here. (Not quite blocker... but meh) b) The new file is missing from the translated installers. (blocker) I'd like to suggest a different approach here. As you can't invent your own keyboard shortcuts, I'd deal with this like with the permissions. Have one SQL file with the mandatory values on top level (not in language directories) and deal with the description translation in the templates. 4) I am wondering if tools is the right place for this. I think I would put it with Sound alerts and column configuration in Administration. 5) If we leave it in tools: It's missing from tools sidebar and start page. If we move to admin, we'll also need sidebar and start page. As the navigation of tools shows on the tool page, I think that makes it currently a bit confusing. 6) Permissions: currently it doesn't require any permission: flagsrequired => {}, Do we want to leave it like this? As the keyboard shortcuts are global and not per user I can imagine libraries would not want anyone be able to reconfigure them. 7) "If combing multiple keys " - interesting idea :) 8) The button is a bit close to the table, could use a little template clean-up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86018|0 |1 is obsolete| | Attachment #86019|0 |1 is obsolete| | Attachment #86020|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88465&action=edit Bug 21411: Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88467&action=edit Bug 21411: Address QA concerns Move to admin Add a permission Remove descriptions from table Clean up template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Something is odd here :( kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove -v t/db_dependent/Koha/KeyboardShortcuts.t t/db_dependent/Koha/KeyboardShortcuts.t .. 1..4 ok 1 - use Koha::KeyboardShortcuts; DBIx::Class::Row::store_column(): No such column 'shortcut_desc' on Koha::Schema::Result::KeyboardShortcut at /home/vagrant/kohaclone/Koha/Object.pm line 75 # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/4 subtests Test Summary Report ------------------- t/db_dependent/Koha/KeyboardShortcuts.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 4 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.50 cusr 0.37 csys = 1.91 CPU) Result: FAIL I've run updatedatabase, dbic, restart_all etc. :( Functionality wise this seems ok so far, can you please have a look? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #21 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89119&action=edit Bug 21411: (QA follow-up) fix tests This patch removes erroneous shortcut_desc from the tests, which was left in accidentally. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Suggested follow-ups: Hide hide the Keyboard settings when Rancor is not activated, similar like other settings are not visible (Plugins, Search engine configs) without the pref. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88466|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89417&action=edit Bug 21411: (follow-up) Missing filters and unused variable POD warnings from QA tool are false positives (basic functionsn POD not needed) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89119|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89419&action=edit Bug 21411: (QA follow-up) fix tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89421&action=edit Bug 21411: (QA follow-up) Fix permission checks on admin page and menu Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement lets you release notes| |globally redefine the | |keyboard shortcuts used in | |rancor. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 [Bug 23396] Rancor fails to load: insert_copyright is not defined -- You are receiving this mail because: You are watching all bug changes.