[Bug 35451] New: Add tablename field to additional_field_values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Bug ID: 35451 Summary: Add tablename field to additional_field_values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Currently we rely on a subquery in the additional_field_values relationships we're adding in various places. For performance and code clarity it would be sensible to add a tablename field to the additional_field_values table to denote which table the value is pertaining to.. we could index this too. This would allow us to drop the subquery and use an indexed field instead during joins. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 [Bug 32751] [Omnibus] Extend, improve and standardize additional fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159390&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159391&action=edit Bug 35451: Record table in set_additional_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159392&action=edit Bug 35451: Update relations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159393&action=edit Bug 35451: Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159394&action=edit Bug 35451: Fix test data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Needs unit tests adding, but posting here as a proof of concept for now looking for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35044 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 [Bug 35044] Additional fields: Allow for repeatable fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159390|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159747&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159391|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159748&action=edit Bug 35451: Record table in set_additional_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159392|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159749&action=edit Bug 35451: Update relations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159393|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159750&action=edit Bug 35451: Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159394|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159751&action=edit Bug 35451: Fix test data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #12 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #13 from David Nind <david@davidnind.com> --- I get this message for a dependency when trying to apply the patches for this bug: git bz apply 35451 Bug 35451 Depends on bug 35044 (Signed Off) Follow? [(y)es, (n)o] y Cannot apply cleanly patches from bug 35044. Everything will be left dirty. git bz apply --continue will not continue the process if patches from other bug reports need to be applied. Once bug 35044 is fixed, I'll have another go at testing. My test plan was to: 1. Apply the patches 2. Update the database: updatedatabase 3. Restart everything (flush_memcached, restart_all) 4. Run the tests - they should pass: prove t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t I wasn't sure what else needs to be tested, or if this is sufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #14 from David Nind <david@davidnind.com> --- Bug 35044 is now in main, however I am now getting the sha1/fake ancestor error: git bz apply 35451 Bug 35451 - Add tablename field to additional_field_values 159747 - Bug 35451: Add record_table to additional_field_values 159748 - Bug 35451: Record table in set_additional_fields 159749 - Bug 35451: Update relations 159750 - Bug 35451: Schema 159751 - Bug 35451: Fix test data Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35451: Add record_table to additional_field_values Applying: Bug 35451: Record table in set_additional_fields Applying: Bug 35451: Update relations Applying: Bug 35451: Schema error: sha1 information is lacking or useless (Koha/Schema/Result/AdditionalFieldValue.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35451: Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159747|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173147&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159748|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173148&action=edit Bug 35451: Record table in set_additional_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159749|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173149&action=edit Bug 35451: Update relations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159750|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173150&action=edit Bug 35451: Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159751|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173151&action=edit Bug 35451: Fix test data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This shouldn't drastically change anything.. it's a performance piece and only really makes a difference where large numbers of additional attributes are defined. No real test plan per say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173147|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 173421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173421&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173148|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 173422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173422&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173149|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 173423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173423&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173150|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 173424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173424&action=edit Bug 35451: Schema Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173151|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 173425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173425&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #26 from David Nind <david@davidnind.com> --- Testing notes (using KTD) - main aim was to make sure everything works as expected: 1. Apply the patch. 2. Update the database: updatedatabase 3. Restart everything: restart_all 4. Run the tests - these should pass: prove t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t 5. Make sure additional fields for acquisition order baskets continue to work as expected: 5.1 Go to Administration > Additional parameters > Additional fields 5.2 Select the table to add additional fields to (in this case, Order baskets (aqbasket)) 5.3 Add a new field: 5.3.1 + New field 5.3.2 Name: TESTFIELD 5.3.3 Repeatable: select 5.3.4 Searchable: select 5.4 Add a new basket to "My Vendor" using the additional field 5.4.1 Go to Acquisitions 5.4.2 In the "Search vendors" section, click "Search" 5.4.3 Add a new order basket: + New > Basket . Basket name: bz35451 . TESTFIELD (add two entries): This is a test + This is a second test 5.4.4 Check that you can edit and delete the entries for your additional field 5.5 Bonus (optional): add different types of additional fields (such as authorized values, or not repeatable) and test that they work SQL === Before the patch, table for additional_field_values - no record_table column: MariaDB [koha_kohadev]> select * from additional_field_values; +----+----------+-----------+-----------------------+ | id | field_id | record_id | value | +----+----------+-----------+-----------------------+ | 1 | 1 | 2 | This is a test | | 2 | 1 | 2 | This is a second test | +----+----------+-----------+-----------------------+ 2 rows in set (0.000 sec) After patch, table for additional_field_values - now has a record_table column: MariaDB [koha_kohadev]> select * from additional_field_values;; +----+----------+--------------+-----------+-----------------------+ | id | field_id | record_table | record_id | value | +----+----------+--------------+-----------+-----------------------+ | 5 | 1 | aqbasket | 2 | This is a test | | 6 | 1 | aqbasket | 2 | This is a second test | +----+----------+--------------+-----------+-----------------------+ 2 rows in set (0.000 sec) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for the testing and signoff David :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 173421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173421 Bug 35451: Add record_table to additional_field_values Review of attachment 173421: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35451&attachment=173421) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +242,4 @@
CREATE TABLE `additional_field_values` ( `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key identifier', `field_id` int(11) NOT NULL COMMENT 'foreign key references additional_fields(id)', + `record_table` varchar(255) NOT NULL DEFAULT '' COMMENT 'tablename of the related record',
Backticks, which should not be used https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks But there are already on all other lines >_< So I don't know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 173422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173422 Bug 35451: Record table in set_additional_fields Review of attachment 173422: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35451&attachment=173422) ----------------------------------------------------------------- ::: Koha/Object/Mixin/AdditionalFields.pm @@ +86,5 @@
+ record_table => $table, + record_id => $self->id, + value => $value, + } + )->store;
It seems a text editor tidied the whole file. Which causes the patch to not apply due to a conflict around here. And hides other changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 173424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173424 Bug 35451: Schema Review of attachment 173424: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35451&attachment=173424) ----------------------------------------------------------------- ::: Koha/Schema/Result/AdditionalFieldValue.pm @@ +71,5 @@
{ data_type => "integer", is_auto_increment => 1, is_nullable => 0 }, "field_id", { data_type => "integer", is_foreign_key => 1, is_nullable => 0 }, + "record_table", + { data_type => "varchar", default_value => "", is_nullable => 0, size => 255 },
The changes on this file should have changed the DBIx checksum -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 173423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173423 Bug 35451: Update relations Review of attachment 173423: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35451&attachment=173423) ----------------------------------------------------------------- ::: Koha/Schema/Result/Subscription.pm @@ -578,5 @@
return { "$args->{foreign_alias}.record_id" => { -ident => "$args->{self_alias}.subscriptionid" }, - - "$args->{foreign_alias}.field_id" => - { -in => \'(SELECT id FROM additional_fields WHERE tablename = "subscription")' },
This change is in the part protected by the checksum but the checksum didn't change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173421|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178332&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173422|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178333&action=edit Bug 35451: Record table in set_additional_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173423|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178334&action=edit Bug 35451: Update relations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173424|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178335&action=edit Bug 35451: Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173425|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178336&action=edit Bug 35451: Fix test data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178332|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178337&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178333|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178338&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178334|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178339&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178340&action=edit Bug 35451: DBIC Schema Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178336|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178341&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #31)
Comment on attachment 173423 [details] [review] Bug 35451: Update relations
Review of attachment 173423 [details] [review]: -----------------------------------------------------------------
::: Koha/Schema/Result/Subscription.pm @@ -578,5 @@
return { "$args->{foreign_alias}.record_id" => { -ident => "$args->{self_alias}.subscriptionid" }, - - "$args->{foreign_alias}.field_id" => - { -in => \'(SELECT id FROM additional_fields WHERE tablename = "subscription")' },
This change is in the part protected by the checksum but the checksum didn't change.
Check again.. it's after the checksum -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #30)
Comment on attachment 173424 [details] [review] Bug 35451: Schema
Review of attachment 173424 [details] [review]: -----------------------------------------------------------------
::: Koha/Schema/Result/AdditionalFieldValue.pm @@ +71,5 @@
{ data_type => "integer", is_auto_increment => 1, is_nullable => 0 }, "field_id", { data_type => "integer", is_foreign_key => 1, is_nullable => 0 }, + "record_table", + { data_type => "varchar", default_value => "", is_nullable => 0, size => 255 },
The changes on this file should have changed the DBIx checksum
This IS the dbic dump patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #28)
Comment on attachment 173421 [details] [review] Bug 35451: Add record_table to additional_field_values
Review of attachment 173421 [details] [review]: -----------------------------------------------------------------
::: installer/data/mysql/kohastructure.sql @@ +242,4 @@
CREATE TABLE `additional_field_values` ( `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key identifier', `field_id` int(11) NOT NULL COMMENT 'foreign key references additional_fields(id)', + `record_table` varchar(255) NOT NULL DEFAULT '' COMMENT 'tablename of the related record',
Backticks, which should not be used https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks
But there are already on all other lines >_< So I don't know.
This isn't IN the table name.. it's quoting the table name.. which is correct as far as I'm aware. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178337|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180806&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> [EDIT] chmod 755 for atomicupdate/bug_35451.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178338|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180807&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178339|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180808&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178340|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180809&action=edit Bug 35451: DBIC Schema Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178341|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180810&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial rebase. Added chmod on atomic update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Acquisition/TransferOrder.t .. 1/15 # Failed test 'transfered order has one additional field value' # at Acquisition/TransferOrder.t line 160. # got: '0' # expected: '1' # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'TransferOrder should copy additional fields' # at Acquisition/TransferOrder.t line 165. Can't call method "value" on an undefined value at Acquisition/TransferOrder.t line 161. # Looks like your test exited with 11 just after 15. Acquisition/TransferOrder.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Please check other tests too using AdditionalFields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180806|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182401&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180807|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182402&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180808|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182403&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180809|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182404&action=edit Bug 35451: DBIC Schema Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180810|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182405&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182406&action=edit Bug 35451: (follow-up) Fix C4::Acquisition::TransferOrder This patch adds table name to the additional fields clone found insdie TransferOrder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182401|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182407&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182402|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182408&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182403|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182409&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182404|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182410&action=edit Bug 35451: DBIC Schema Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182405|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182411&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182406|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182412&action=edit Bug 35451: (follow-up) Fix C4::Acquisition::TransferOrder This patch adds table name to the additional fields clone found insdie TransferOrder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #65 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182413&action=edit Bug 35451: (follow-up) Save join in C4::Serials::DelSubscription We can use the new record_table field to save ourselves a join in here too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #66 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Marcel de Rooy from comment #52)
Acquisition/TransferOrder.t .. 1/15 # Failed test 'transfered order has one additional field value' # at Acquisition/TransferOrder.t line 160. # got: '0' # expected: '1' # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run.
# Failed test 'TransferOrder should copy additional fields' # at Acquisition/TransferOrder.t line 165. Can't call method "value" on an undefined value at Acquisition/TransferOrder.t line 161. # Looks like your test exited with 11 just after 15. Acquisition/TransferOrder.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
Please check other tests too using AdditionalFields
Good catch, thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Bug 35451 depends on bug 35044, which changed state. Bug 35044 Summary: Additional fields: Allow for repeatable fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182407|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187210&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182408|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187211&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182409|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187212&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182410|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187213&action=edit Bug 35451: DBIC Schema Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182411|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187214&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182412|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187215&action=edit Bug 35451: (follow-up) Fix C4::Acquisition::TransferOrder This patch adds table name to the additional fields clone found insdie TransferOrder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182413|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187216&action=edit Bug 35451: (follow-up) Save join in C4::Serials::DelSubscription We can use the new record_table field to save ourselves a join in here too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187210|0 |1 is obsolete| | --- Comment #74 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187464&action=edit Bug 35451: Add record_table to additional_field_values This patch updates the database to include a record_table field in the additional_field_values table and adds an index on that field. This should facilitate more performant joins. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187211|0 |1 is obsolete| | --- Comment #75 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187465&action=edit Bug 35451: Record table in set_additional_fields Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187212|0 |1 is obsolete| | --- Comment #76 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187466&action=edit Bug 35451: Update relations Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187213|0 |1 is obsolete| | --- Comment #77 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187467&action=edit Bug 35451: DBIC Schema Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187214|0 |1 is obsolete| | --- Comment #78 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187468&action=edit Bug 35451: Fix test data Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187215|0 |1 is obsolete| | --- Comment #79 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187469&action=edit Bug 35451: (follow-up) Fix C4::Acquisition::TransferOrder This patch adds table name to the additional fields clone found insdie TransferOrder. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187216|0 |1 is obsolete| | --- Comment #80 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187470&action=edit Bug 35451: (follow-up) Save join in C4::Serials::DelSubscription We can use the new record_table field to save ourselves a join in here too. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #81 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187471&action=edit Bug 35451: (QA follow-up) Add newlines to updated DBIC files as per Bug 40541 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | --- Comment #82 from Paul Derscheid <paul.derscheid@lmscloud.de> --- This is a great change. Makes it easier to grasp, too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #83 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Ive updated the database but I cant make tests pass: prove -v /kohadevbox/koha/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t /kohadevbox/koha/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1..13 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'record_table' in 'field list' at /kohadevbox/koha/Koha/Object.pm line 174 not ok 1 - no warnings # Failed test 'no warnings' # at /usr/share/perl/5.36/Test/Builder.pm line 193. # There were 1 warning(s) # Previous test 0 '' # DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'record_table' in 'field list' at /kohadevbox/koha/Koha/Object.pm line 174 # at /kohadevbox/koha/Koha/Object.pm line 179. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #84 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm afraid I can't get the test to fail here Lucas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #85 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize (ashimema) from comment #84)
I'm afraid I can't get the test to fail here Lucas
OK, could have just been me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #86 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41520 [Bug 41520] Using additional fields on ERM agreements results in an error when loading the agreements table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #87 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backporting to 25.05 as this is an enhancement. Happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 --- Comment #88 from David Nind <david@davidnind.com> --- No changes to the manual required - no visible change to the UI or change in functionality for staff. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org