[Bug 27397] New: Serials: The description input field when defining numbering patterns is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Bug ID: 27397 Summary: Serials: The description input field when defining numbering patterns is too short Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When adding or editing a numbering pattern in the serials module the description input field is quite short which makes adding and editing notes unnecessarily hard. To test: - go to the serials module - click on manage numbering patterns in the left hand navigation - add or edit a pattern - check the description field is as short as the name field, but can take much more text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #1 from Catherine <catherinem2003@gmail.com> --- Created attachment 115261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115261&action=edit Bug 25054: (QA follow-up) Add space after comma for multiple aliases Just a little formatting change to help readability by adding a space after comma: alias1, alias2, ... Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Catherine Ma <catherinem2003@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=27397 Signed-off-by: Catherine Ma <catherinem2003@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115261|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherinem2003@gmail.com Assignee|koha-bugs@lists.koha-commun |catherinem2003@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #2 from Catherine <catherinem2003@gmail.com> --- Created attachment 115289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115289&action=edit Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Catherine, I don't think the following change is needed: - <input type="text" id="label" name="label" value="[% label | html %]" /> + <input type="text" id="label" name="label" value="[% label | html %]" > -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115289|0 |1 is obsolete| | --- Comment #4 from Catherine <catherinem2003@gmail.com> --- Created attachment 115361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115361&action=edit Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de --- Comment #5 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- I don't know wheter this has something to do with this patch. I got an error after klicking on the Save button for saving a new numbering pattern at testing this patch. The description field is indeed longer than before. First lines of error trace: C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_christian8`.`subscription_numberpatterns`.`displayorder` at row 1 [for Statement "INSERT INTO subscription_numberpatterns(label,description,numberingmethod,displayorder,label1,label2,label3,add1,add2,add3,every1,every2,every3,setto1,setto2,setto3,whenmorethan1,whenmorethan2,whenmorethan3,numbering1,numbering2,numbering3) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)" with ParamValues: 0="blablub", 1="blablubdescription", 2="{X}, H. {Y} {Z} ", 3="", 4="Jahr", 5="Jahrgang", 6="Heft", 7="1", 8="1", 9="1", 10="12", 11="6", 12="1", 13="1", 14="1", 15="1", 16="9999", 17="9999", 18="6", 19="", 20="", 21=""] at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 62 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #6 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- Addition: if i'm emptying the Numbering formula field, i won't get an error after saving, but the New numbering pattern won't be saved (on the surface?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The order appears when you create a new numbering patterns and the "display order" is empty. It's a bug that is not directly related to this patch and bug report. Can you open a new one please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)
The order appears when you create a new numbering patterns and the "display order" is empty. It's a bug that is not directly related to this patch and bug report. Can you open a new one please?
s/order/error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28012 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115361|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #9 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118590&action=edit Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118809&action=edit Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Sponsored by Catalyst IT Works OK! Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial display fix, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | CC| |andrew@bywatersolutions.com --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org