[Bug 32351] New: Fix TestBuilder calls in Koha/Holds.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Bug ID: 32351 Summary: Fix TestBuilder calls in Koha/Holds.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org See 32350. Follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 [Bug 32350] Should we die if TestBuilder is passed a column we're not expecting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144236&action=edit Bug 32351: Holds.t - replace biblionumber by biblio_id Trivial fix, found by bug 32350. Note that the test also passes without this value hash ;) Test plan: Run test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix TestBuilder calls in |Fix all TestBuilder calls |Koha/Holds.t |failing due to wrong column | |names (see 32350) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144236|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144240&action=edit Bug 32351: Holds.t - remove wrong column reference Found by bug 32350. The test does not need this value at all.. Test plan: Run test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144243&action=edit Bug 32351: Fix Acquisition.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144244&action=edit Bug 32351: Fix Budgets.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144249&action=edit Bug 32351: Fix Illrequests.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144250&action=edit Bug 32351: Fix Members.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144251&action=edit Bug 32351: Fix Reserves.t itemtypes.notforloan already defaults to 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144252&action=edit Bug 32351: Fix Circulation.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should this be NSO rather than Assigned? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Let's leave it ASSIGNED and we just keep adding patches here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144240|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144243|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144244|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144249|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144250|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144251|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144252|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144353&action=edit Bug 32351: Holds.t - remove wrong column reference Found by bug 32350. The test does not need this value at all.. Test plan: Run test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144354&action=edit Bug 32351: Fix Acquisition.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144355&action=edit Bug 32351: Fix Budgets.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144356&action=edit Bug 32351: Fix Illrequests.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144357&action=edit Bug 32351: Fix Members.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144358&action=edit Bug 32351: Fix Reserves.t itemtypes.notforloan already defaults to 0 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144359&action=edit Bug 32351: Fix Circulation.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144360&action=edit Bug 32351: Fix CourseItems.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144361&action=edit Bug 32351: Fix TemplateToolkit.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144362&action=edit Bug 32351: Fix Koha/Patrons.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144363&action=edit Bug 32351: Fix t/db_dependent/api/v1/patrons.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144364&action=edit Bug 32351: Fix t/db_dependent/Circulation/NoIssuesChargeGuarantees.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144365&action=edit Bug 32351: Fix t/db_dependent/Koha/Charges/Sales.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #24)
Pushed to master for 22.11.
Nice work everyone, thanks!
Thx Tomas for your acceleration here :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome work here, thanks :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Summary|Fix all TestBuilder calls |Fix all TestBuilder calls |failing due to wrong column |failing due to wrong column |names (see 32350) |names --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks, Tomas! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |jacob.omara@ptfs-europe.com Version(s)|23.05.00 |23.05.00, 22.11.01 released in| | --- Comment #28 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work! Pushed to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org