[Bug 23122] New: When searching callnumber in simple search, search option is not retained
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Bug ID: 23122 Summary: When searching callnumber in simple search, search option is not retained Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To test: - Go to the OPAC - Select callnumber from the search pull down on top - Search for anything, 'test' will work - Verify that the search option switches back to 'library catalog' - Repeat with 'Series' - Verfiy that search option is still 'Series' after sending search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90603&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90603|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 90615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90615&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90615|0 |1 is obsolete| | --- Comment #3 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90624&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90624|0 |1 is obsolete| | --- Comment #4 from Arthur Bousquet <arthur.bousquet@inlibro.com> --- Created attachment 90626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90626&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90626|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90627&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Owen for the super quick fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.02 released in| | --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org